Create bipartite.py #2060

jntushar · 2020-06-02T06:07:33Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new Python files are placed inside an existing directory.
All filenames are in all lowercase characters with no spaces or dashes.
All functions and variable names follow Python naming conventions.
All function parameters and return values are annotated with Python type hints.
All functions have doctests that pass the automated testing.
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.


        Create bipartite.py

cclauss · 2020-06-02T07:11:38Z

https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

graphs/bipartite.py


        Update bipartite.py

graphs/bipartite.py


        Update graphs/bipartite.py

Co-authored-by: Christian Clauss <[email protected]>


        Update bipartite.py


        Update bipartite.py

jntushar · 2020-06-02T07:51:58Z

Code is working fine in my local machine...i don't understand why it is failing here

cclauss · 2020-06-02T07:54:22Z

What input are you giving the program??

./graphs/bipartite.py:25: Explaination ==> Explanation
./graphs/bipartite.py:39: Explaination ==> Explanation
./graphs/bipartite.py:44:1: E302 expected 2 blank lines, found 1

cclauss · 2020-06-02T07:55:21Z

What is n and what is m and why does the reader need to guess?


        Update bipartite.py


        Update bipartite.py

jntushar · 2020-06-02T08:25:13Z

Now it can be merged.

graphs/bipartite.py


        Update graphs/bipartite.py

Co-authored-by: Christian Clauss <[email protected]>

cclauss · 2020-06-07T05:48:34Z

graphs/bipartite.py

@@ -35,6 +35,12 @@


 def bipartite(partition: list, adjacent_edges: list) -> int:


Suggested change

def bipartite(partition: list, adjacent_edges: list) -> int:

def bipartite(partition: list, adjacent_edges: list) -> bool:

It would be more Pythonic to return True or False instead of 0 or 1

cclauss · 2020-06-07T06:03:52Z

graphs/bipartite.py

+    step = 2
+    while queue:
+        node = queue.pop(0)
+        flag = 0


What is flag measuring? Could we please have a more self documenting variable name? It should be a bool (True/False), not 0/1.

cclauss · 2020-06-07T06:34:30Z

graphs/bipartite.py

+    return 1
+
+
+def colour(adjacent_edges):  # Assigning alternative colours to the nodes of the graph


Can we please have type hints and doctests for this function too?

cclauss · 2020-06-07T06:34:30Z

graphs/bipartite.py

+    queue = []
+    queue.append(0)


Suggested change

queue = []

queue.append(0)

queue = [0]

cclauss · 2020-06-07T06:34:30Z

graphs/bipartite.py

+                if step % 2 == 0:
+                    partition[i] = 'B'
+                else:
+                    partition[i] = 'W'


Suggested change

if step % 2 == 0:

partition[i] = 'B'

else:

partition[i] = 'W'

partition[i] = 'W' if step % 2 else 'B'

cclauss · 2020-06-07T06:34:30Z

graphs/bipartite.py

+                    partition[i] = 'B'
+                else:
+                    partition[i] = 'W'
+        if flag == 1:


Suggested change

if flag == 1:

if flag:

cclauss · 2020-06-07T06:34:30Z

graphs/bipartite.py

+                    partition[i] = 'W'
+        if flag == 1:
+            step += 1
+    return bipartite(partition, adjacent_edges)  # return 1 if the graph is bipartite and 0 otherwise.


Suggested change

return bipartite(partition, adjacent_edges) # return 1 if the graph is bipartite and 0 otherwise.

# return True if the graph is bipartite or False if it is not.

return bipartite(partition, adjacent_edges)

Lines must not be longer than 88 characters max as discussed in CONTRIBUTING.md.

cclauss · 2020-06-07T06:34:30Z

graphs/bipartite.py

+    user_input = sys.stdin.read()
+    data = list(map(int, user_input.split()))


Suggested change

user_input = sys.stdin.read()

data = list(map(int, user_input.split()))

data = [int(x) for x in input("Enter integers separated by spaces").split()]

cclauss · 2020-06-07T07:14:33Z

On your machine do python -m doctest -v pipartite.py to make sure that the doctests pass.
https://travis-ci.com/github/TheAlgorithms/Python/builds/170125057#L747

stale · 2020-07-08T01:52:29Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Create bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

8c71d4d

cclauss reviewed Jun 2, 2020

View changes

graphs/bipartite.py Outdated Show resolved Hide resolved

cclauss reviewed Jun 2, 2020

View changes

graphs/bipartite.py Outdated Show resolved Hide resolved

Update bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

fb64776

cclauss reviewed Jun 2, 2020

View changes

graphs/bipartite.py Outdated Show resolved Hide resolved

jntushar and others added 3 commits Jun 2, 2020

Update graphs/bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

39b2495

Co-authored-by: Christian Clauss <[email protected]>

Update bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

7a2a789

Update bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

16b3e4e

jntushar added 2 commits Jun 2, 2020

Update bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

5817c19

Update bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

8d23cac

cclauss reviewed Jun 2, 2020

View changes

graphs/bipartite.py Show resolved Hide resolved

cclauss self-assigned this Jun 2, 2020

cclauss added the Tests are needed label Jun 2, 2020

Update graphs/bipartite.py

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

7d18379

Co-authored-by: Christian Clauss <[email protected]>

cclauss reviewed Jun 7, 2020

View changes

graphs/bipartite.py

step = 2

while queue:

node = queue.pop(0)

flag = 0

This comment has been minimized.

Sign in to view

Copy link

cclauss Jun 7, 2020
Member

What is flag measuring? Could we please have a more self documenting variable name? It should be a bool (True/False), not 0/1.

cclauss requested changes Jun 7, 2020

View changes

stale bot added the wontfix label Jul 8, 2020

Jun	JUL	Aug
	08
2019	2020	2021

TheAlgorithms / Python

Create bipartite.py #2060

Create bipartite.py #2060

jntushar commented Jun 2, 2020 •

edited

cclauss commented Jun 2, 2020

jntushar commented Jun 2, 2020

cclauss commented Jun 2, 2020

cclauss commented Jun 2, 2020

jntushar commented Jun 2, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cclauss commented Jun 7, 2020 •

edited by onlinejudge95

stale bot commented Jul 8, 2020

		@@ -35,6 +35,12 @@


		def bipartite(partition: list, adjacent_edges: list) -> int:

		return 1


		def colour(adjacent_edges): # Assigning alternative colours to the nodes of the graph

	return bipartite(partition, adjacent_edges) # return 1 if the graph is bipartite and 0 otherwise.
	# return True if the graph is bipartite or False if it is not.
	return bipartite(partition, adjacent_edges)

		user_input = sys.stdin.read()
		data = list(map(int, user_input.split()))

	user_input = sys.stdin.read()
	data = list(map(int, user_input.split()))
	data = [int(x) for x in input("Enter integers separated by spaces").split()]

TheAlgorithms / Python

Join GitHub today

Create bipartite.py #2060

Create bipartite.py #2060

Conversation

jntushar commented Jun 2, 2020 • edited

Describe your change:

Checklist:

cclauss commented Jun 2, 2020

jntushar commented Jun 2, 2020

cclauss commented Jun 2, 2020

cclauss commented Jun 2, 2020

jntushar commented Jun 2, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cclauss commented Jun 7, 2020 • edited by onlinejudge95

stale bot commented Jul 8, 2020

jntushar commented Jun 2, 2020 •

edited

cclauss commented Jun 7, 2020 •

edited by onlinejudge95