The Wayback Machine - https://web.archive.org/web/20200708151611/https://github.com/Wox-launcher/Wox/issues/1853
Skip to content

/ Wox

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell plugin needs an initial space to trigger / Make keywords match without spaces #1853

Open
harrynull opened this issue Jan 22, 2018 · 1 comment
Open

Shell plugin needs an initial space to trigger / Make keywords match without spaces #1853

harrynull opened this issue Jan 22, 2018 · 1 comment
Labels
suggestion

Comments

@harrynull
Copy link

@harrynull harrynull commented Jan 22, 2018

Are you submitting a bug report?

Yes

Steps to reproduce

Type >ping 127.0.0.1, nothing happens.
Type > ping 127.0.0.1, the plugin starts to work.
I am not sure if it is expected or not, but in either way, it's annoying since the space is redundant (we already have ">" as the trigger).

Screenshots (optional)

image
No result shows
image
It needs an initial space to work
@lances101
Copy link
Member

@lances101 lances101 commented Jan 22, 2018

Wox, as do many other launchers, works on a basis of keywords. > is a keyword to activate the shell plugin.

Some other plugins, like the Color plugin can be invoked without a space because the keyword for it is set to none. What it does then is check if the first character in a query is # and wait for a valid color. This approach can cause some issues:

wox fff

While this is an extreme case as its rare to actually have a file named #fff, it serves as a good example of why the Shell plugin was initially developed by using keywords.

All of that said, > is an invalid character for filenames, so it would be possible to make your use case possible without breaking results completely.

Another option is actually adding the option of having keywords match without spaces, which is more global and makes more sense. Definitely a good suggestion, thanks.
@lances101 lances101 changed the title Shell plugin needs an initial space to trigger Shell plugin needs an initial space to trigger / Make keywords match without spaces Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion
2 participants
@lances101 @harrynull
You can’t perform that action at this time.