The Wayback Machine - https://web.archive.org/web/20200708033042/https://github.com/TheAlgorithms/Python/pull/2062
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doubly linked list algorithm #2062

Open
wants to merge 3 commits into
base: master
from
Open

Fix doubly linked list algorithm #2062

wants to merge 3 commits into from
+91 −55

Conversation

@TheSuperNoob
Copy link
Contributor

TheSuperNoob commented Jun 2, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@TheSuperNoob
Fix doubly linked list algorithm
Loading status checks…
40efd77
@TheSuperNoob
Copy link
Contributor Author

TheSuperNoob commented Jun 2, 2020

This also includes adding the doctests from #2052
@mquevill
mquevill suggested changes Jun 22, 2020
View changes
data_structures/linked_list/doubly_linked_list.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Jun 23, 2020
View changes
data_structures/linked_list/doubly_linked_list.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Jun 23, 2020
View changes
data_structures/linked_list/doubly_linked_list.py Outdated Show resolved Hide resolved
@TheSuperNoob
Fix bug with insert_at_tail method
Loading status checks…
cefc034 
Create __str__() method for Node class and LinkedList class
@mquevill

This comment has been minimized.

Sign in to view
Copy link
Contributor

mquevill commented on data_structures/linked_list/doubly_linked_list.py in cefc034 Jun 23, 2020

The only concern about returning a string when the list is empty is that it makes it seem like there's something in the list.

>>> from doubly_linked_list import *
>>> dll = LinkedList()
>>> print(dll)
List is empty
>>> dll = LinkedList()
>>> dll.insert_at_tail("List")
>>> dll.insert_at_tail("is")
>>> dll.insert_at_tail("empty")
>>> print(dll)
List is empty
>>> dll = LinkedList()
>>> dll.insert_at_tail("List is empty")
>>> print(dll)
List is empty

This comment has been minimized.

Sign in to view
Copy link
Member

cclauss replied Jun 23, 2020

I would simply return what str(list()) returns.
@TheSuperNoob
Simplify __str__() of LinkedList
Loading status checks…
c6d1b1a 
Returns empty string if there are no elements in the list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@TheSuperNoob @cclauss @mquevill
You can’t perform that action at this time.