The Wayback Machine - https://web.archive.org/web/20201017210915/https://github.com/asdf-vm/asdf/pull/742
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: synchronize help text #742

Merged
merged 8 commits into from Jun 16, 2020
Merged

Conversation

@jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Jun 14, 2020

Summary

The help text and "All Commands" doc site page have been getting updates differently. They've fallen out of sync. While crude, I would like to solve the discrepancy by directly importing the help.txt file into the docs.

I don't imagine that page to be heavily visited, it was only included for completeness of the documentation site. This is a better in-between.

Other Information

I removed the 2 space indentation of the help.txt for all commands. This allows for more content to be horizontally filled.

I removed the inline word wrapping. I will follow this PR up with a change to render the help text via awk on asdf/asdf help and perform wrapping.

@jthegedus jthegedus requested a review from asdf-vm/core as a code owner Jun 14, 2020
@jthegedus jthegedus self-assigned this Jun 14, 2020
help.txt Outdated
asdf plugin remove <name> Remove plugin and package versions
asdf plugin update <name> [<git-ref>] Update a plugin to latest commit or a particular git-ref.
asdf plugin update --all Update all plugins
asdf plugin add <name> [<git-url>] Add a plugin from the plugin repo OR, add a Git repo as a plugin by specifying the name and repo url

This comment has been minimized.

@Stratus3D

Stratus3D Jun 15, 2020
Member

I think we should still wrap this text at 80 columns. I work on pretty small screens and my terminal is usually around 80 columns.

help.txt Outdated
asdf install [<name> <version>] Install a specific version of a package or, with no arguments, install all the package versions listed in the .tool-versions file
asdf install <name> latest[:<version>] Install the latest stable version of a package, or with optional version, install the latest stable version that begins with the given string
asdf uninstall <name> <version> Remove a specific version of a package
asdf current Display current version set or being used for all packages

This comment has been minimized.

@Stratus3D

Stratus3D Jun 15, 2020
Member

This is what I see with wrapping text. I find it hard to follow when it wraps all the way around. Screen Shot 2020-06-15 at 12 25 30 PM

Copy link
Member

@Stratus3D Stratus3D left a comment

I would prefer we continue to wrap text around 80 columns but all the changes to the help text itself look good to me!

@jthegedus
Copy link
Contributor Author

@jthegedus jthegedus commented Jun 15, 2020

My goal here was to remove the inline formatting and rely on the print mechanism to perform formatting. Currently help is output with cat, I want to change this to awk for consistency. I will revert the inline wrapping (though it wasn't at 80, more like 90-95) and include the final formatting change with awk formatting

jthegedus added 2 commits Jun 15, 2020
@jthegedus
Copy link
Contributor Author

@jthegedus jthegedus commented Jun 15, 2020

Here's a diff from the last two commits showing strict vs relaxed 80 char wrapping. Relaxed doesn't wrap individual words.

https://github.com/asdf-vm/asdf/compare/6638ba0..0f275d1

@jthegedus
Copy link
Contributor Author

@jthegedus jthegedus commented Jun 15, 2020

I'd like to get this in and will follow up in another PR with formatting being moved into the printing function and not the content.

@jthegedus jthegedus merged commit 605be10 into asdf-vm:master Jun 16, 2020
5 checks passed
5 checks passed
test (macos-latest)
Details
test (ubuntu-latest)
Details
test (windows-latest) test (windows-latest)
Details
lint
Details
format
Details
@jthegedus jthegedus deleted the jthegedus:docs/sync-help-text branch Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.