Hi all, our bug scanner has reported some NPE bugs.

1.The first one is at FileInJarReadableDataSource.java#L99 since the variable inputStream may be null.

2.The second one is at [SimpleHttpClient.java#L1

It should be set to True to counter count per most specific rule, not to add to most general rule. It is not clear from description. I saw this. May be need to update docs to make it clear.

As you point out in the documentation

If, from the same IP, in the same second, you'll make two calls to api/values, the last call will get blocked. But if in the same second you call api/values/1 too, the request will go through because it's a different route.

Is there any development / workaround to consider

/api/values
and
/api/values/{0}

the same in terms of throttling?

Hi, I've noticed that Bottleneck just uses the default priority any time a floating priority value, and it does not seem to be documented this behavior, or even that an integer is required.

Both the documentation should be improved about this matter, and Math.floor combined with Math.min and Math.max should be used to sanitize any number.

The token bucket algorithm is well explained in many papers and wiki pages. But, Bucket4j is token-bucket on steroids, Bucket4j contain several addons to original math foundation of token bucket, but requests like this vladimir-bukhtoyarov/bucket4j#86 point that these addons are not well explained. To close documentation dept it is need to dedicated page with many real exam

Type: feature request

Describe what feature you want

Add Nacos dynamic data-source module for Sentinel. Detailed design is needed.

See https://github.com/mailgun/gubernator/blob/master/architecture.md#side-effects-of-global-behavior

It states: Using GLOBAL can increase the amount of traffic per rate limit request if the cluster is large enough

I assume that with 'the cluster' you mean the cluster of gubernator instances.

Can you give a more detailed indication what you mean with '_large'? Are we talking about te

We should have more backends, because this project aims to be maximally useful in a variety of architectures. Perhaps:

• Mnesia
• Postgres (or a generic SQL backend? Probably Ecto)
• MongoDB
• ???

I've implemented rate limiting as documented in the readme:

@on_exception(expo, RateLimitException, max_tries=8)
@limits(calls=15, period=FIFTEEN_MINUTES)
def call_api(url):
    response = requests.get(url)
    ...

But I would like a way to effectively turn off this rate-limiting while running tests. I've not found any concise examples on stackoverflow on how mock a dec

The second cat command is missing the apiVersion line.
Should be:

cat <<EOF | kubectl apply -f -
apiVersion: networking.istio.io/v1alpha3

Also, in the current version of Istio, we need to run:

kubectl apply -f samples/bookinfo/networking/virtual-service-all-v1.yaml -n default
kubectl apply -f samples/bookinfo/networking/destination-rule-all-mtls.yaml -n default

instead

Currently the rate limiting is not implemented before auth or body parsing is done. This create potential situations where some load is not shed from the server when it could have been,

Is the library thread-safe? Docs don't mention, but I would assume it is, because it's being used in contexts that are normally multi-threaded (e.g. Flask-Limiter).

However, when I was using the library in multi-threaded context (with high concurrency), I randomly hit into:

  ...
  File "/home/musttu/.pyenv/versions/his/lib/python3.5/site-packages/limits/strategies.py", line 130, i