The Wayback Machine - https://web.archive.org/web/20201222224625/https://github.com/goodboy/tractor/issues/111
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about duplication between tests and examples (also run as tests)? #111

Open
goodboy opened this issue Feb 10, 2020 · 2 comments
Open

Comments

@goodboy
Copy link
Owner

@goodboy goodboy commented Feb 10, 2020

As per #98, in #102 we added proper testing of (almost) all examples in the docs (more land in #99 too).

One of the issues is that some of these examples are also re-implemented in the test suite.
The duplication between examples in examples/ and what's in the tests is hard to avoid currently since the test currently take some of the documented examples and parameterize them with things like different delays to cancellation or different numbers of actors spawned. I'm not sure we can really avoid the duplication really. Maybe someone will come up with a bright idea to simplify it all without adding confusion?

@goodboy
Copy link
Owner Author

@goodboy goodboy commented Jun 23, 2020

Wait did we solve this already?

@goodboy
Copy link
Owner Author

@goodboy goodboy commented Aug 4, 2020

It might mean de-duplicating by just removing some tests that are duplicating the new example script set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.