The Wayback Machine - https://web.archive.org/web/20200920211525/https://github.com/kaj/ructe/pull/80
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tide example #80

Merged
merged 3 commits into from Jul 28, 2020
Merged

add tide example #80

merged 3 commits into from Jul 28, 2020

Conversation

@prabirshrestha
Copy link
Contributor

prabirshrestha commented Jun 6, 2020

Add tide example. PR for #79

In ructe_tide.rs I used full qualified namespace so that others can easily copy paste their code in main.rs or other projects and is easy to onboard.

@prabirshrestha prabirshrestha force-pushed the prabirshrestha:ructe-tide branch from 8d2cb48 to 4d88fc7 Jun 6, 2020
@kaj
Copy link
Owner

kaj commented Jul 16, 2020

Thank you for the example! In the end, I would like to have an example comple with static files, simliar to the warp and other exampes, but this will do nicely as a starting point.

The CI was broken when you pushed, so no tests was executed. On the other hand, there's no test for this example anyway, as this example is not yet listed in .travis.yml.

@kaj
Copy link
Owner

kaj commented Jul 16, 2020

Seems I could commit on your branch, so I added the required lines to .travis.yml, and that triggered a test run.

@kaj kaj added the enhancement label Jul 19, 2020
@kaj kaj merged commit 15d1cbe into kaj:master Jul 28, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@prabirshrestha prabirshrestha deleted the prabirshrestha:ructe-tide branch Jul 28, 2020
kaj added a commit that referenced this pull request Aug 14, 2020
* PR #80 and #94: Support Tide framework by a feature and an example.
* PR #91: Update basic examples to edition 2018.
* Issue #68, PR #90: Don't eat whitespace after a for loop.
* Issue #66, PR #89: Fix parse error for nested braces in expressions.
* PR #84: Use std::ascii::escape_default.
* PR #87: Provide ToHtml::to_buffer()
* Forbid unsafe and undocumented code.
* The build is on https://travis-ci.com/kaj/ructe now.
* Internal cleanup.

Thanks to @Aunmag and @prabirshrestha for reported issues and
contributed code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.