The Wayback Machine - https://web.archive.org/web/20210207110941/https://github.com/google/ExoPlayer/pull/7232
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fmp4 tests to Increase coverage of fmp4 Extractors #7232

Closed
wants to merge 3 commits into from

Conversation

@jparekh-tivo
Copy link

@jparekh-tivo jparekh-tivo commented Apr 14, 2020

AtomParsers and FragmentedMp4Extractor

Added some more samples with various mp4 box combinations to enhance coverage of mp4 extractors

@googlebot
Copy link
Collaborator

@googlebot googlebot commented Apr 14, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 14, 2020
@jparekh-tivo
Copy link
Author

@jparekh-tivo jparekh-tivo commented Apr 14, 2020

@googlebot I signed it!

@ojw28
Copy link
Contributor

@ojw28 ojw28 commented Apr 14, 2020

@kim-vde - Please take a look
@jparekh-tivo - You'll need to fix the CLA issue before we can merge this

@ojw28 ojw28 requested a review from kim-vde Apr 14, 2020
…xtractor

Added some more samples with various mp4 box combinations to enhace coverage of mp4 extractors
@jparekh-tivo jparekh-tivo force-pushed the TiVo:p-fmp4-smpte-unit-tests branch from 04315b1 to c76aaaf Apr 14, 2020
…xtractor

Added some more samples with various mp4 box combinations to enhace coverage of mp4 extractors
@jparekh-tivo jparekh-tivo force-pushed the TiVo:p-fmp4-smpte-unit-tests branch 2 times, most recently Apr 14, 2020
…nto p-fmp4-smpte-unit-tests
@jparekh-tivo jparekh-tivo force-pushed the TiVo:p-fmp4-smpte-unit-tests branch to 8f56eea Apr 14, 2020
@ojw28
Copy link
Contributor

@ojw28 ojw28 commented Apr 20, 2020

@jparekh-tivo - There are still CLA issues that need resolving with this PR. Could you take a look?

@jparekh-tivo
Copy link
Author

@jparekh-tivo jparekh-tivo commented Apr 20, 2020

@ojw28 I am working on that. Will get in touch with the contact person from my organisation.

@ojw28
Copy link
Contributor

@ojw28 ojw28 commented May 14, 2020

@jparekh-tivo - Any update on the CLA issue? Thanks!

@ojw28
Copy link
Contributor

@ojw28 ojw28 commented Jun 22, 2020

@jparekh-tivo - What's the status of this pull request?

@ojw28
Copy link
Contributor

@ojw28 ojw28 commented Aug 26, 2020

@jparekh-tivo @stevemayhew - What's the status of this pull request? We would like to merge it, but it doesn't have a signed CLA, and there's not much to be gained from leaving it open and pending indefinitely. Thanks!

@ojw28
Copy link
Contributor

@ojw28 ojw28 commented Sep 8, 2020

Please do let us know if you're able to fix the CLA and contribute these, but closing for now due to lack of any updates.

@ojw28 ojw28 closed this Sep 8, 2020
@google google locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants