The Wayback Machine - https://web.archive.org/web/20201122152707/https://github.com/sindresorhus/got/issues/936
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests / features #936

Open
sindresorhus opened this issue Nov 18, 2019 · 1 comment
Open

Add more tests / features #936

sindresorhus opened this issue Nov 18, 2019 · 1 comment

Comments

@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Nov 18, 2019

We never have enough tests. There are just so many edge-cases in HTTP and networking that the more the merrier.

It could be useful to look at other popular request libraries and take see if they have tests we are missing:

We could also looks at these libraries for ideas of missing features and API improvements.

@szmarczak szmarczak changed the title Add more tests Add more tests / features Nov 24, 2019
@szmarczak
Copy link
Collaborator

@szmarczak szmarczak commented Nov 24, 2019

I think we should also document some useful Node options such as localAddress.
A guide on how to write your own request function would be nice IMO (an example: http2-wrapper).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.