The Wayback Machine - https://web.archive.org/web/20200703015705/https://github.com/validatorjs/validator.js/issues/1266
Skip to content

/ validator.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(README): add the supported locales for various validators #1266

Open
profnandaa opened this issue Mar 5, 2020 · 4 comments
Open

chore(README): add the supported locales for various validators #1266

profnandaa opened this issue Mar 5, 2020 · 4 comments
Labels
good first issue help wanted

Comments

@profnandaa
Copy link
Collaborator

@profnandaa profnandaa commented Mar 5, 2020

e.g. isPassportNumber, etc.
@tux-tn
Copy link
Contributor

@tux-tn tux-tn commented Mar 13, 2020

@profnandaa i was thinking about fixing it the other day and i had a little concern, should we rename countryCode to locale to have consistent naming across the lib?
@profnandaa
Copy link
Collaborator Author

@profnandaa profnandaa commented Mar 15, 2020

@tux-tn -- sure, standardization will be great. However, we will have backward compatibility to deal with.
@tux-tn
Copy link
Contributor

@tux-tn tux-tn commented Mar 16, 2020

@profnandaa can i work on a PR where we can accept a string and an array as a parameter and rename it to locale in the documentation?
@profnandaa
Copy link
Collaborator Author

@profnandaa profnandaa commented Mar 22, 2020

@tux-tn -- can give an example?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted
2 participants
@profnandaa @tux-tn
You can’t perform that action at this time.