The Wayback Machine - https://web.archive.org/web/20200619222708/https://github.com/twbs/bootstrap/pull/30414
Skip to content

/ bootstrap

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 dep updates and backports #30414

Merged
merged 9 commits into from Mar 31, 2020
Merged

V4 dep updates and backports #30414

merged 9 commits into from Mar 31, 2020
+2,038 −1,949

Conversation

@XhmikosR
Copy link
Member

XhmikosR commented Mar 17, 2020 •
edited

Preview: https://deploy-preview-30414--twbs-bootstrap.netlify.com/
@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation Mar 17, 2020
@XhmikosR XhmikosR requested a review from mdo Mar 18, 2020
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from 58ec832 to a54be72 Mar 18, 2020
@XhmikosR XhmikosR changed the title V4 Update deps and switch to Ruby 2.6 V4 dep updates and backports Mar 18, 2020
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from a3b415a to 41d8856 Mar 18, 2020
@XhmikosR XhmikosR requested a review from twbs/js-review as a code owner Mar 20, 2020
@Johann-S
Johann-S approved these changes Mar 22, 2020
View changes
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from eb955e3 to 35bd3e8 Mar 23, 2020
@XhmikosR XhmikosR removed this from Inbox in v4.5.0 Mar 23, 2020
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 2 times, most recently from 2ddd6ea to bf70f94 Mar 25, 2020
@XhmikosR XhmikosR requested a review from twbs/css-review as a code owner Mar 25, 2020
@XhmikosR XhmikosR requested a review from MartijnCuppens Mar 25, 2020
@XhmikosR XhmikosR removed the dependencies label Mar 25, 2020
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from 562a8c3 to 6cf4b95 Mar 25, 2020
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 26, 2020

@ffoodd @MartijnCuppens @patrickhlauke the #30073 backport is nice for v4-dev, but since the navbar occupies the whole width, the skip links overlap with it. Just pointing it out. I personally don't really like this :/
@ffoodd
Copy link
Contributor

ffoodd commented Mar 26, 2020

I agree, it's more awkward in v4-dev.

I see two workarounds (that could match to master as well):

  1. use a colored backplate and make it a sort of sticky-top element (just like Github's one!)
  2. keep the previous pushing design, just left-aligning skip-links (being at the top left is the main goal of this PR) — may consider to make both skip-links visible at once on docs, in that case. This could look weird in v5 since the whole layout is centered.

Depending on what we consider to do, I'll open a PR against master or v4-dev.

Any thoughts?
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from 6cf4b95 to 4dec444 Mar 28, 2020
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 29, 2020

@mdo @MartijnCuppens thoughts how to proceed with the skip links in this branch?
XhmikosR and others added 7 commits Mar 17, 2020
@XhmikosR
CI: switch to Ruby 2.6.
21e6021
@XhmikosR @mdo
Clarify card group behavior (#30416)
666a2cf 
Co-authored-by: Mark Otto <markd.otto@gmail.com>
@XhmikosR
Backport (#30418)
3146b4f 
Open icons in a new tab like the rest of the external links
@Johann-S @XhmikosR
Backport (#30383)
7ca9738 
fix: ensure totype always return stringified null when null passed
@ysds @XhmikosR
Update modal docs (#30325)
200a383
@XhmikosR
Backport #30041 and #30448
c6b63b0 
Switch links to the GitHub organization and fix redirected links
@timdujardin @XhmikosR
Added focus state to .btn-link (#30036)
c36d124
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from 4dec444 to 7028dad Mar 31, 2020
@XhmikosR
Remove holder.js leftovers (#30469)
1e3341e
@XhmikosR
Bump devDependencies and gems.
Loading status checks…
7fbcf50
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from 7028dad to 7fbcf50 Mar 31, 2020
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 31, 2020

I removed the docs skip links patch for now and pushed it to https://github.com/twbs/bootstrap/tree/v4-dev-docs-skip-links

@MartijnCuppens mentioned some issues with master too so we better discuss this more and/or revert the patch from master in the meantime.
@MartijnCuppens MartijnCuppens mentioned this pull request Mar 31, 2020
Open
@MartijnCuppens
MartijnCuppens approved these changes Mar 31, 2020
View changes
@XhmikosR XhmikosR merged commit 0225c11 into v4-dev Mar 31, 2020
8 checks passed
8 checks passed
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
bundlesize Total bundle size is 173.98KB/176.25KB (-null)
Details
coverage/coveralls Coverage remained the same at 91.587%
Details
deploy/netlify Deploy preview ready!
Details
@XhmikosR XhmikosR deleted the v4-dev-xmr branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4
6 participants
@XhmikosR @ffoodd @Johann-S @MartijnCuppens @ysds @timdujardin
You can’t perform that action at this time.