The Wayback Machine - https://web.archive.org/web/20200626074020/https://github.com/actions/stale/pull/58
Skip to content

/ stale

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale labels and ignore stale issues with comments #58

Merged
merged 6 commits into from May 11, 2020
Merged

Remove stale labels and ignore stale issues with comments #58

merged 6 commits into from May 11, 2020

Conversation

@hross
Copy link
Contributor

hross commented May 2, 2020 •
edited

Addresses #21: Ignore issues that have comments on them

  • Check each issue for comments since the stale label was applied. If they exist, don't close the issue.
  • Add an option to allow the stale label to be removed by the bot (off by default)

TODO:

  1. Fix failing tests
  2. (optional) Make the method injection for the test suite less burdensome (mocking or a fake client)
  3. Add more tests
  4. Test this logic on some real repos
hross added 2 commits May 2, 2020
@hross
First pass at ignorning issues with comments and allowing removal of …
cd198e6 
…the stale label
@hross
Fix up tests a bit to make this runnable (tests failing though)
Loading status checks…
5a67f40
@hross hross mentioned this pull request May 2, 2020
Open
@donavanbecker
donavanbecker approved these changes May 3, 2020
View changes
@donavanbecker
Copy link

donavanbecker commented May 3, 2020

@shawnnapora can we get this merged?
@damccorm
damccorm approved these changes May 4, 2020
View changes
Copy link
Contributor

damccorm left a comment

This generally LGTM
@hross
Copy link
Contributor Author

hross commented May 4, 2020

I still need to fix the failing tests and the other TODOs before I can merge this
hross added 4 commits May 11, 2020
@hross
Add debugging, update tests and fix logic.
Loading status checks…
51cc467
@hross
Add a test for un-staling
379e98c
@hross
Add vscode debug settings
Loading status checks…
299593d
@hross
Default un-stale to true in new version
Loading status checks…
7a47124
@hross hross merged commit 3838b88 into master May 11, 2020
2 checks passed
2 checks passed
build build
Details
test test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@hross @donavanbecker @damccorm
You can’t perform that action at this time.