Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: GitLab OIDC Provider #519
Conversation
CLAassistant
commented
Jun 17, 2020
•
|
|
| func (g *ProviderGitLab) Claims(ctx context.Context, exchange *oauth2.Token) (*Claims, error) { | ||
| tokenSource := oauth2.StaticTokenSource(exchange) | ||
| client := oauth2.NewClient(ctx, tokenSource) | ||
| req, err := http.NewRequest("GET", "https://gitlab.com/oauth/userinfo", nil) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
perryao
Aug 10, 2020
Author
Based on https://gitlab.com/.well-known/openid-configuration returning "issuer": "https://gitlab.com", I'm going to assume that I can just concatenate /oauth/userinfo to whatever the user puts into their kratos config for issuerUrl. Otherwise, I'll default to https://gitlab.com
perryao
force-pushed the
perryao:feat/gitlab-selfservice
branch
from
df679d6
to
74ed3bd
|
@aeneasr reviewing CONTRIBUTING.md, it states
The history in strategy/oidc suggests I should prefix the commits with either Do you have a preference? |
|
Sorry for my super-late reply! Don't worry about the commit message, I'll squash merge it and pick an appropriate message :) |
|
Thank you for the great work and sorry for the late review, the last few days were really stressful and I didn't have time to review all the PRs :) This looks great, I've added a small addition. I think the last remaining point would be to document how to set up GitLab over here: https://www.ory.sh/kratos/docs/guides/sign-in-with-github-google-facebook-linkedin Thank you! :) |
perryao
force-pushed the
perryao:feat/gitlab-selfservice
branch
from
8db9ebe
to
305305f
|
Could you fix the build issues please? :) |
|
@aeneasr I'm sorry this took me so long to get back to. I merged in the latest from master to resolve conflicts and fixed the build issues. |
|
No worries - it's great that you are contributing :) I left another comment answering one of your questions in the PR |
perryao commentedJun 17, 2020
•
edited
Related issue
Would close #518
Proposed changes
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments