The Wayback Machine - https://web.archive.org/web/20200713011433/https://github.com/ballercat/walt/issues/129
Skip to content

/ walt

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type declarations for walt-loader. #129

Open
Chamberlain91 opened this issue Jul 25, 2018 · 1 comment
Open

Type declarations for walt-loader. #129

Chamberlain91 opened this issue Jul 25, 2018 · 1 comment
Labels
good first issue help wanted

Comments

@Chamberlain91
Copy link

@Chamberlain91 Chamberlain91 commented Jul 25, 2018

Feature Request

Today I found that walt-loader doesn't work seamlessly in a webpack environment using typescript because its missing type declarations.

This is the type file I've used:

type WaltInstantiate = (deps?: any) => Promise<WebAssembly.ResultObject>

declare module "*.walt" {
    const value: WaltInstantiate
    export default value;
}

where WebAssembly.ResultObject is defined in @types/emscripten.
@ballercat
Copy link
Owner

@ballercat ballercat commented Jul 30, 2018

Other than the parts that overlap with JS I have next to zero knowledge of TypeScript. If you'd like to add some type definitions (or a types file? I don't know how that works), I would accept a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted
2 participants
@ballercat @Chamberlain91
You can’t perform that action at this time.