The Wayback Machine - https://web.archive.org/web/20200625015139/https://github.com/PaperMC/Paper/issues/1733
Skip to content

/ Paper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.13 Tab Completion for Aliases / Plugin Command Replacements #1733

Open
Zefferis opened this issue Dec 7, 2018 · 6 comments
Open

1.13 Tab Completion for Aliases / Plugin Command Replacements #1733

Zefferis opened this issue Dec 7, 2018 · 6 comments
Labels
help wanted we must go deeper

Comments

@Zefferis
Copy link

@Zefferis Zefferis commented Dec 7, 2018 •
edited

What behaviour is expected:

Proper tab complete for alias commands from commands.yml
The /give command is shared between EssentialsX and Vanilla; ideal fix would be assigning it an alias in the commands.yml file to direct /give to the /minecraft:give command, and retain tab completion to the alias.

What behaviour is observed:

Tab completion for /give only provides usernames, and goes on forever.
image

Steps/models to reproduce:

commands.yml

aliases:
  give:
  - minecraft:give $1-

paper.yml

settings:
  suggest-player-names-when-null-tab-completions: false

\plugins\Essentials\config.yml

disabled-commands:
  - give

Plugin list:

EssentialsX 2.15.0.56 (b660)

Paper build number:

Paper b474

Anything else:

Could there be potential for "priority" commands? Listing vanilla commands that will not become secondary to plugin commands?

I could very well just not be doing this correctly, but I just want to retain proper tab completion for a vanilla command that's been overridden by a plugin.
@Zefferis
Copy link
Author

@Zefferis Zefferis commented Dec 10, 2018 •
edited

It appears that this was previously reported to spigot in bug report:
https://hub.spigotmc.org/jira/browse/SPIGOT-2819
This was reported Nov 21, 2016 but no action's have been taken there

It would be wonderful if paper or spigot could define commands from vanilla that will not be overridden by plugins.

Such that a plugin that has a command like:
essentials:give which conflicts with minecraft:give can be negated to retain vanilla behavior of /give without the use of aliases in commands.yml which have a tab completion problem.

Maybe a potential option in commands.yml like:

ignore-plugin-commands:
 - give
 - enchant
 - list
 - ect.
@Spottedleaf
Copy link
Contributor

@Spottedleaf Spottedleaf commented Dec 11, 2018 •
edited

To me it looks like essentials should properly implement command disabling. It still registers the command, which is why tabcomplete is going through.

EDIT:
Here is how essentials handles disabled commands:
https://github.com/EssentialsX/Essentials/blob/2.x/Essentials/src/com/earth2me/essentials/Essentials.java#L486

EDIT#2:
Looking at the commands.yml format, the only issue arises is that you can define an alias to multiple commands.
@Zefferis Zefferis mentioned this issue Dec 11, 2018
Closed
@Zefferis
Copy link
Author

@Zefferis Zefferis commented Dec 11, 2018

EssentialsX responded, part of their response was:

In addition, EssentialsX also makes a conscious effort to hand over tab completion to other commands, but we can't do this with vanilla commands as they are not plugin commands.

Ideally, server software would provide a way to let vanilla commands take precedence, because doing this in EssentialsX would require an uncomfortable amount of tying behavior to the implementation instead of the API.

I think this is fair; since a variety of plugins could be overriding vanilla commands,

Counting on plugin devs to properly handle these situations isn't as realistic as spigot or paper keeping certain listed vanilla commands top priority and not letting plugins take them over 🤷‍♂️
@Derkades Derkades mentioned this issue Jul 3, 2019
Open
@Toadby
Copy link

@Toadby Toadby commented Feb 27, 2020

Is there any update on this? Ran into it on Paper for 1.15.2, with EssentialsX 2.17.1.0.
@electronicboy
Copy link
Member

@electronicboy electronicboy commented Feb 27, 2020

This isn't really viable for aliases given the nature of how they work, bukkit doesn't really offer much to deal with this, ideally, the command map would be exposed so that plugins can just not register commands if they're disabled...
@Toadby
Copy link

@Toadby Toadby commented Feb 27, 2020

I haven't tested it but as far as I can tell this plugin claims to have this functionality, but is no longer maintained.
https://dev.bukkit.org/projects/xsimplealias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted we must go deeper
5 participants
@electronicboy @zachbr @Spottedleaf @Zefferis @Toadby
You can’t perform that action at this time.