Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
7,864 contributions in the last year
Activity overview
Contribution activity
June 2020
Created a pull request in ColorlibHQ/AdminLTE that received 11 comments
Add bundlewatch
IMO it's useful, but you might not want to do it :) That being said, the limits I chose are mostly strict. You can tweak them as needed. Also, this…
+277
−0
•
11
comments
- Fix comment
- CardWidget: fix `minimize()` CSS
- ControlSidebar.js: minor simplification
- Update browserslist config
- Use template literals
- Be explicit with the background color property
- Remove `.nav-tabs-custom` references
- Ignore more plugin files.
- Switch to String constants
- Update dependencies
- Use Bootstrap 4.4 consistently.
- Fix accordion example
- Ignore inputmask.binding.js
- vnu: enable `Werror`
- Deps
- Unbreak lines
- Fix typo in comment
- Add missing trailing slash in docs link.
- layout.md: Escape `\`
- Add back jsgrid/demos/db.js
- Load the minified summernote CSS
- language-menu.html: load flag-icon-css locally
- Rename variable for clarity
- HTML Pages tag cleanup
- chartjs.html: switch to `$.` like everywhere else
- Some pull requests not shown.
- README.md: use unpkg.com in badgesize badges
- Update devDependencies
- Minor JS tweaks
- Update bundlewatch.yml
- Rename "master" to "main".
- Fix BootstrapCDN's name
- Templates
- README: remove `.svg` from shields.io badges
- Release v5.0.0-alpha1
- Fix a broken link and a redirect.
- Tighten bundlewatch limits
- Replace serve with sirv-cli.
- Update devDependencies
- Update lint.yml
- Clean up .babelrc.js and remove `@babel/plugin-proposal-object-rest-s…
- Stylelint: remove redundant disables
- Update Actions
- Update devDependencies
- Revisit our browserslist config
- V4 dev backports and updates
- Regenerate package-lock.json
- Remove HTML from titles when not needed.
- footer.js: remove dead code.
- network.js: use `utils.datetime()`
- Remove the unused iCheck.min.js
- Tweak CSP
- Move scripts to the footer.
- Fix typo "Long term" -> "Long-term"
- Tailog pages: make checkboxes use the same markup as everywhere else.
- Update xo to v0.32.0 and regenerate package-lock.json
- Fix tailog pages IDs
- Update chartjs to v2.9.3
- Docs: Fix typo
- input-file: create a plugin
- Docs: change sidebar collapse controls to actual button elements
- Fix Stack Overflow tag
- Add new toasts examples
- Docs: tweak accessibility section
- Docs: add Gaël Poupard to the core team page
- data: reword storage key in dom
- Docs: fix old/broken example capture and typo
- Change whitelist to allowlist
- Bump terser from 4.7.0 to 4.8.0
- Bump rollup from 2.15.0 to 2.16.1
- Update links to bug and feature request issue templates
- Fix typo
- v5: Port new homepage changes
- v5: Add role=button cursor in Reboot
- v5: Update favicons
- Add .rotate-* utilities
- Run dist on latest
- v5: Redo blockquote attributions
- buttons plugin : avoid multiple change event trigger
- v4 — zero `min-width` on .col has too much side-effect
- avoid preventing input event onclick
- Bump @rollup/plugin-commonjs from 12.0.0 to 13.0.0
- Remove .nav-item from .nav-link to make it consistent
- Some pull request reviews not shown.
- build(deps-dev): bump stylelint from 13.6.0 to 13.6.1
- build(deps-dev): bump stylelint from 13.5.0 to 13.6.0
- build(deps): bump sass from 1.26.7 to 1.26.8
- build(deps-dev): bump remark-preset-lint-node from 1.15.0 to 1.15.1
- build(deps-dev): bump stylelint-config-twbs-bootstrap from 2.0.2 to 2.0.3
- build(deps-dev): bump vnu-jar from 20.3.16 to 20.5.29
- build(deps): bump sass from 1.26.5 to 1.26.7
- Improve filtering on table pages
- Fix static DHCP lease removal in dev
- Prevent possible XSS attack vector in the input fields of the group section
- Improve conditional forwarding settings
- PHP intval() should be all lowercase
- Add support for HOSTNAME diagnostics message
- Change "Permanently" toggle to "Indefinitely"
Created an issue in ColorlibHQ/AdminLTE that received 6 comments
[BUG] Move CSS outside of JS
I mark it as a bug, because it reduces performance. It's faster to add/remove a CSS class than setting/getting CSS properties via jQuery. Now, this…
6
comments
- This should be simplified later. There's no reason for us not to use unique classes in the buttons.
- Revisit `setTimeout` calls
- Revisit cookies
- Move token and network colors in data attributes?
- Revisit `require` vs `require_once` usage
- Remove `initCheckboxRadioStyle()`
- Move inline `style`s to pi-hole.css
- Revisit CSP further
- Move HTML outside of JS whenever possible
- Revisit `.html()`/`innerHtml` usage
- Revisit `utils.showAlert()`
- [FEATURE] Improve plugins copy scripts
- [FEATURE] Scss: use the mixins whenever possible
- @REJack it seems this introduced a regression: the `sidebar-is-opening` is not removed after the sidebar is visible.
- [FEATURE] Add a script to bump the version
- [BUG] jsgrid examples don't work
- [BUG] Remove flot-old
- [BUG] Move demo{1,2,3}.js files after 3rd-party JS files
- [BUG] sparklines seems unused
- [BUG] Remove jQuery UI from pages that don't need it
- [FEATURE] Add a script to create the dist zip file
- [BUG] Fix docs baseurl
51
contributions
in private repositories
Jun 2 – Jun 16