The Wayback Machine - https://web.archive.org/web/20210124135226/https://github.com/uber/aresdb/pull/245
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker file error for update to go 1.11 #245

Merged
merged 2 commits into from Jul 14, 2019
Merged

Conversation

@yutiansut
Copy link
Contributor

@yutiansut yutiansut commented Jul 13, 2019

fix docker file error in different go version

errors in #244

1. different go path in change go version

in this PR

just change the go version from 1.9 to 1.11.4

however the gopath in DockerFile not been changed

already fixed

2. go 1.11+'s rule, we should set GO111MODULE

ENV GO111MODULE=on

already fixed

success output

after that:

root@60eadc19dd6d:~/go/src/github.com/uber/aresdb# make run_server
[ 11%] Built target mem
[100%] Built target algorithm
[100%] Built target lib
[100%] Built target aresd
Scanning dependencies of target run_server
Using config file:  config/ares.yaml
{"level":"info","msg":"Bootstrapping service","config":{"Port":9374,"DebugPort":43202,"RootPath":"ares-root","TotalMemorySize":161061273600,"SchedulerOff":false,"Version":"","Env":"","Distributed":false,"Query":{"DeviceMemoryUtilization":0.95,"DeviceChoosingTimeout":10,"TimezoneTable":{"TableName":"api_cities"},"EnableHashReduction":false},"DiskStore":{"WriteSync":true},"HTTP":{"MaxConnections":300,"ReadTimeOutInSeconds":20,"WriteTimeOutInSeconds":300},"Cluster":{"Enable":false,"ClusterName":"","InstanceName":"60eadc19dd6d"},"Gateway":{"Controller":null},"RedoLogConfig":{"Namespace":"","DiskConfig":{"Disabled":false},"KafkaConfig":{"Enabled":false,"Brokers":null,"TopicSuffix":""}},"InstanceConfig":{"ID":"","Namespace":"","Etcd":{"Zone":"","Env":"","Service":"","CacheDir":"","ETCDClusters":null,"SDConfig":{"InitTimeout":null},"WatchWithRevision":0},"HeartbeatConfig":{"Timeout":0,"Interval":0}}}}
{"level":"info","msg":"Reading schema from local MetaStore ares-root/metastore"}
{"level":"info","msg":"Initialized device manager","utilization":0.949999988079071,"timeout":10}
{"level":"info","msg":"DeviceInfo[0]={DeviceID:0 QueryCount:0 TotalMemory:25576865792 TotalAvailableMemory:24298022912 FreeMemory:24298022912 QueryMemoryUsageMap:map[]}\n"}
{"level":"info","msg":"Bootstrapping device"}
{"level":"info","msg":"Finish bootstrapping device"}
{"level":"info","msg":"Initializing shards from local DiskStore ares-root"}
{"level":"info","msg":"HostMemoryManager: initial preloading done"}
{"level":"info","msg":"Start loading snapshots for all table shards"}
{"level":"info","msg":"Finish loading snapshots for all table shards"}
{"level":"info","msg":"Starting archiving scheduler"}
{"level":"info","msg":"Start replaying redo logs for all table shards"}
{"level":"info","msg":"Finish replaying redo logs for all table shards"}
{"level":"info","msg":"Starting HTTP server on port 9374 with max connection 300"}
{"level":"info","msg":"Starting HTTP server on dbg-port 43202"}

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jul 13, 2019

CLA assistant check
All committers have signed the CLA.

@yutiansut
Copy link
Contributor Author

@yutiansut yutiansut commented Jul 14, 2019

also the GO111MODULE=on should be set in the ENV of docker file for go version 11+'s rule

@codecov-io
Copy link

@codecov-io codecov-io commented Jul 14, 2019

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files         159      159           
  Lines       21304    21304           
=======================================
  Hits        14728    14728           
  Misses       5452     5452           
  Partials     1124     1124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8177b4...a8fb33e. Read the comment docs.

@yutiansut
Copy link
Contributor Author

@yutiansut yutiansut commented Jul 14, 2019

all success

root@60eadc19dd6d:~/go/src/github.com/uber/aresdb# make run_server
[ 11%] Built target mem
[100%] Built target algorithm
[100%] Built target lib
[100%] Built target aresd
Scanning dependencies of target run_server
Using config file:  config/ares.yaml
{"level":"info","msg":"Bootstrapping service","config":{"Port":9374,"DebugPort":43202,"RootPath":"ares-root","TotalMemorySize":161061273600,"SchedulerOff":false,"Version":"","Env":"","Distributed":false,"Query":{"DeviceMemoryUtilization":0.95,"DeviceChoosingTimeout":10,"TimezoneTable":{"TableName":"api_cities"},"EnableHashReduction":false},"DiskStore":{"WriteSync":true},"HTTP":{"MaxConnections":300,"ReadTimeOutInSeconds":20,"WriteTimeOutInSeconds":300},"Cluster":{"Enable":false,"ClusterName":"","InstanceName":"60eadc19dd6d"},"Gateway":{"Controller":null},"RedoLogConfig":{"Namespace":"","DiskConfig":{"Disabled":false},"KafkaConfig":{"Enabled":false,"Brokers":null,"TopicSuffix":""}},"InstanceConfig":{"ID":"","Namespace":"","Etcd":{"Zone":"","Env":"","Service":"","CacheDir":"","ETCDClusters":null,"SDConfig":{"InitTimeout":null},"WatchWithRevision":0},"HeartbeatConfig":{"Timeout":0,"Interval":0}}}}
{"level":"info","msg":"Reading schema from local MetaStore ares-root/metastore"}
{"level":"info","msg":"Initialized device manager","utilization":0.949999988079071,"timeout":10}
{"level":"info","msg":"DeviceInfo[0]={DeviceID:0 QueryCount:0 TotalMemory:25576865792 TotalAvailableMemory:24298022912 FreeMemory:24298022912 QueryMemoryUsageMap:map[]}\n"}
{"level":"info","msg":"Bootstrapping device"}
{"level":"info","msg":"Finish bootstrapping device"}
{"level":"info","msg":"Initializing shards from local DiskStore ares-root"}
{"level":"info","msg":"HostMemoryManager: initial preloading done"}
{"level":"info","msg":"Start loading snapshots for all table shards"}
{"level":"info","msg":"Finish loading snapshots for all table shards"}
{"level":"info","msg":"Starting archiving scheduler"}
{"level":"info","msg":"Start replaying redo logs for all table shards"}
{"level":"info","msg":"Finish replaying redo logs for all table shards"}
{"level":"info","msg":"Starting HTTP server on port 9374 with max connection 300"}
{"level":"info","msg":"Starting HTTP server on dbg-port 43202"}

@yutiansut yutiansut changed the title Update Dockerfile for https://github.com/uber/aresdb/issues/244 fix docker file error for update to go 1.11 Jul 14, 2019
@shz117
shz117 approved these changes Jul 14, 2019
Copy link
Contributor

@shz117 shz117 left a comment

yeah it was a left over from previous go version migration.
thanks for the fix!

@shz117 shz117 merged commit cef7ad6 into uber:master Jul 14, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants