The Wayback Machine - https://web.archive.org/web/20200906062619/https://github.com/microsoft/tsyringe/issues/82
Skip to content

/ tsyringe

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that `.reset()` removes all registrations #82

Open
Xapphire13 opened this issue Jan 22, 2020 · 4 comments
Open

Document that `.reset()` removes all registrations #82

Xapphire13 opened this issue Jan 22, 2020 · 4 comments
Assignees
@Xapphire13
Labels
accepting PRs documentation

Comments

@Xapphire13
Copy link
Collaborator

@Xapphire13 Xapphire13 commented Jan 22, 2020

Describe the bug
Currently there is ambiguity over how .reset() behaves (see #28 (comment)).

We should document the exact behavior to make it clear

Version: n/a
@Xapphire13 Xapphire13 self-assigned this Jan 22, 2020
@Xapphire13 Xapphire13 mentioned this issue Jan 22, 2020
Closed
@xenoterracide xenoterracide mentioned this issue Feb 22, 2020
Open
@xenoterracide
Copy link
Contributor

@xenoterracide xenoterracide commented Feb 22, 2020

per my ticket on #96 I think that reset() should be deprecated and replaced with unregisterAll(). I'm considering working on these tickets as this is currently impeding me. Let me know what you think.
@Xapphire13
Copy link
Collaborator Author

@Xapphire13 Xapphire13 commented Apr 26, 2020

@xenoterracide, sounds good. So .unregisterAll() would replace .reset(); what would the API look like for disposing of singleton instances?
@xenoterracide
Copy link
Contributor

@xenoterracide xenoterracide commented Apr 26, 2020

clearInstances?
@Xapphire13
Copy link
Collaborator Author

@Xapphire13 Xapphire13 commented Apr 26, 2020

Sounds good to me! Would be awesome if you still had the bandwidth for it =]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PRs documentation
2 participants
@xenoterracide @Xapphire13
You can’t perform that action at this time.