The Wayback Machine - https://web.archive.org/web/20200617133321/https://github.com/paularmstrong/normalizr/issues/430
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in denormalize() behavior from 3.2.3 => 3.2.4 when passing objects as input #430

Open
swieder227 opened this issue Jan 7, 2020 · 0 comments

Comments

@swieder227
Copy link

@swieder227 swieder227 commented Jan 7, 2020

Repro

Here's my repro case:
https://jsfiddle.net/sethwieder/L46en8b2/40/

Expected

We're passing in an object as the input and expected it to denormalize nested objects based on the provided schema.

Actual

The output duplicate the same item for each index in the input array.

Context

This used to work in 3.2.3, but no longer works as of 3.2.4.

It's unclear to me if this is even correct usage of denormalize(), as the docs just say:
"the normalized result that should be de-normalized. Usually the same value that was given in the result key of the output of normalize." - is this expected to only work with IDs as inputs?

It's also unclear from the tag changelog what exactly caused this change in behavior and if it's expected or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.