Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange in denormalize() behavior from 3.2.3 => 3.2.4 when passing objects as input #430
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


Repro
Here's my repro case:
https://jsfiddle.net/sethwieder/L46en8b2/40/
Expected
We're passing in an object as the input and expected it to denormalize nested objects based on the provided schema.
Actual
The output duplicate the same item for each index in the input array.
Context
This used to work in 3.2.3, but no longer works as of 3.2.4.
It's unclear to me if this is even correct usage of denormalize(), as the docs just say:
"the normalized result that should be de-normalized. Usually the same value that was given in the result key of the output of normalize." - is this expected to only work with IDs as inputs?
It's also unclear from the tag changelog what exactly caused this change in behavior and if it's expected or not