The Wayback Machine - https://web.archive.org/web/20200531212215/https://github.com/gregnb/mui-datatables/issues/974
Skip to content

/ mui-datatables

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create better loading indicator experiences in serverside examples to enhance demonstration #974

Open
gabrielliwerant opened this issue Oct 3, 2019 · 3 comments
Open

Create better loading indicator experiences in serverside examples to enhance demonstration #974

gabrielliwerant opened this issue Oct 3, 2019 · 3 comments
Labels
enhancement good first issue

Comments

@gabrielliwerant
Copy link
Collaborator

@gabrielliwerant gabrielliwerant commented Oct 3, 2019 •
edited

In the serverside-pagination example, we have some sample means of adding loading indicators. Loading indicators are a common and important part of the serverside experience, so we should have some better examples here so that other devs can work from good ideas, and we can keep full-fledged loading indicator options out of the core library (E.g. #958).

  • Create more realistic, good UX loading indicator example(s) in the serverside-pagination example.
@jose-donato
Copy link

@jose-donato jose-donato commented Jan 17, 2020

image

For example this? It hasn't the search problem referred in #958.
@gabrielliwerant
Copy link
Collaborator Author

@gabrielliwerant gabrielliwerant commented Jan 19, 2020

@jose-donato In your screenshot, which is the action that causes the loading indicator to appear?
@jose-donato
Copy link

@jose-donato jose-donato commented Jan 22, 2020

getData = () => { this.setState({ isLoading: true }); this.xhrRequest().then(res => { this.setState({ data: res.data, isLoading: false, count: res.total }); }); };

The getData function, the same it was before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
2 participants
@gabrielliwerant @jose-donato
You can’t perform that action at this time.