Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[Doc request] Add unit/e2e tests to repo's samples #1539
Labels
Comments
|
@kamilmysliwiec Any updates on this? New user here -would love to use right techniques |
|
Please submit only one Pull Request per sample. These contributions do have a great impact on NestJS. Not only will you provide better documentation for developers (the sample folder is a widely used resource to look up real-world examples) but also improve NestJSs integration tests. If you need help with your Pull Request, you can find good resources on the Hacktoberfest website. Additionally, you can always ask for support at our Discord channel. Happy hacking! :) |
|
A sample e2e test.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


I'm submitting a...
Current behavior
Samples in nest/samples are missing examples of unit and/or e2e tests. Particularly of interest to me is 05-sql-typeorm, but other samples seem to be the same. Sample 01-cats-app contains some tests, but they are quite basic.
ExpectedDesired behaviorSamples for specific features/techniques include unit and/or e2e tests pertaining to those features/techniques. For example, the sample given above (05) could include tests that show how to test endpoints, mock data, or connect to a testing database.
Minimal reproduction of the problem with instructions
Sample 05-sql-typeorm. Notably, the tests/ dir and /src/**/*.spec.ts files are not present. Also, they are excluded by the samples' local gitignore.
What is the motivation / use case for changing the behavior?
Environment
Nest version: master branch
For Tooling issues: N/A
Others: N/A