The Wayback Machine - https://web.archive.org/web/20200628203431/https://github.com/playcanvas/engine/issues/851
Skip to content

/ engine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lightmapper-reserved bits to larger values #851

Open
guycalledfrank opened this issue Feb 16, 2017 · 0 comments
Open

Change lightmapper-reserved bits to larger values #851

guycalledfrank opened this issue Feb 16, 2017 · 0 comments
Labels
area: graphics enhancement

Comments

@guycalledfrank
Copy link
Contributor

@guycalledfrank guycalledfrank commented Feb 16, 2017

Lightmapper reserves first 3 bits to filter dynamic lights: https://github.com/playcanvas/engine/blob/master/src/scene/lightmapper.js#L4
It would be better to change their values to something larger, because it's tempting for users to change the first bits when they're working with bit masks, and then lightmapper can unexpectedly override those.
@guycalledfrank guycalledfrank self-assigned this Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics enhancement
2 participants
@willeastcott @guycalledfrank
You can’t perform that action at this time.