Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate typings for default export and config #189
Merged
Conversation
The current index.d.ts file, when compiled with TypeScript 3.1, would give the following error:
```
./node_modules/push.js/index.d.ts:3:20
TS2714: The expression of an export assignment must be an identifier or qualified name in an ambient context.
./node_modules/push.js/index.d.ts:14:9
TS7010: 'config', which lacks return-type annotation, implicitly has an 'any' return type.
```
VicXXX left a comment
|
Hey can we get that in in TypeScript 2.9 i get a lot of warnings because of that. |
|
What do you mean? Compiling my patch with tsc 2.9.2 produces no warnings at all. |
VicXXX
commented
Oct 18, 2018
I mean the current Push.js pulled from NPM has those errors. I want your PR to go in. |
|
@natsukagami Welcome to push.js and thanks a lot for your first PR ! The fix makes sense. I would try to merge and draft a release asap as it seems to be already affecting people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
natsukagami commentedOct 9, 2018
•
edited
The current index.d.ts file, when compiled with TypeScript 3.1, would give the following error:
I attempted a minimal fix to the above problem.
This change is