The Wayback Machine - https://web.archive.org/web/20200609101056/https://github.com/bukosabino/ta/issues/50
Skip to content

/ ta

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #50

Open
joarleymoraes opened this issue Apr 6, 2019 · 2 comments
Open

Tests #50

joarleymoraes opened this issue Apr 6, 2019 · 2 comments
Labels
good first issue

Comments

@joarleymoraes
Copy link

@joarleymoraes joarleymoraes commented Apr 6, 2019

Hey there,

Nice job with this library!

Can I ask why you have no (unit) tests to verify the correctness of the implementation of the indicators ?

I may be able to contribute there.

Cheers,
@bukosabino
Copy link
Owner

@bukosabino bukosabino commented Apr 6, 2019

Hi @joarleymoraes ,

This is a really good requirement.

The more important thing here would be how to obtain example quality dataset for every indicator. Perhaps, https://stockcharts.com is a good baseline to do it.

Of course, you are invited to contribute!
@bukosabino
Copy link
Owner

@bukosabino bukosabino commented Nov 7, 2019

Hi @joarleymoraes

I have added tests for some indicators. You can check it here: https://github.com/bukosabino/ta/tree/master/ta/tests

Also, you can execute it:

python -m unittest discover

I think this is a good first issue to start helping in the development of the library.

Best,
Dario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
2 participants
@bukosabino @joarleymoraes
You can’t perform that action at this time.