Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upserialtube misbehaves when opening the serial port fails #1411
Labels
Comments
|
Would you mind submitting a PR solving some of this? And possibly adding some doctests to ensure this does not break again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


Hi! I noticed two minor bugs with how failure to open serialtube() is handled:
serial.serialutil.SerialExceptionrather thanPwnlibException(which is the one thrown by all other tubes when opening fails)Here is a small test case (make sure the port is actually busy before running this):
Additionally, documentation for the serialtube module is quite lacking (as in, there is basically no documentation and you have to look at the source code to see e.g. how
convert_newlinesis handled)