The Wayback Machine - https://web.archive.org/web/20200528084229/https://github.com/uber/makisu/pull/223
Skip to content

/ makisu

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use basic auth on AWS, otherwise all the registries would fail authentication #223

Merged
merged 1 commit into from May 14, 2019
Merged

Only use basic auth on AWS, otherwise all the registries would fail authentication #223

merged 1 commit into from May 14, 2019

Conversation

@Rowern
Copy link
Contributor

Rowern commented May 14, 2019 •
edited

Again, my change introduced too much error, it was a bad idea to assume that all registry implement basic auth, let's limit basic auth to aws and expand it if needs be.
@Rowern Côme Tresarrieu
Only use basic auth on AWS, otherwise all the registries would fail a…
Loading status checks…
de91c2e 
…uthentication
@Rowern Rowern changed the title Only use basic auth on AWS, otherwise all the registries would fail a… Only use basic auth on AWS, otherwise all the registries would fail authentication May 14, 2019
@Rowern Rowern mentioned this pull request May 14, 2019
Merged
@yiranwang52
yiranwang52 approved these changes May 14, 2019
View changes
@yiranwang52 yiranwang52 merged commit 92443c6 into uber:master May 14, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Failed
Details
license/cla Contributor License Agreement is signed.
Details
yiranwang52 added a commit that referenced this pull request Jul 16, 2019
@Rowern @yiranwang52
Only use basic auth on AWS, otherwise all the registries would fail a…
Loading status checks…
6f71681 
…uthentication (#223)
@yiranwang52 yiranwang52 mentioned this pull request Jul 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Rowern @yiranwang52
You can’t perform that action at this time.