The Wayback Machine - https://web.archive.org/web/20201221014754/https://github.com/microsoft/react-native-windows/pull/2655
Skip to content

/ react-native-windows

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up some basic formatting configuration for vscode #2655

Merged
merged 8 commits into from Jul 1, 2019
Merged

Hook up some basic formatting configuration for vscode #2655

merged 8 commits into from Jul 1, 2019

Conversation

@acoates-ms
Copy link
Collaborator

@acoates-ms acoates-ms commented Jun 20, 2019 •
edited

  • Copies the clang-format and prettier configs from react-native.
  • Adds the clang-format and prettier extensions to the list of recommended extensions in vscode.
  • Moves from tslint to eslint, and adopts the community rule set
  • Use eslint to run prettier
  • Add CI verification that code is linted correctly

Things coming later:

  • Add a git hook to enforce formatting of new code
  • Reformatting all the existing code
Microsoft Reviewers: Open in CodeFlow
@acoates-ms
Hook up some basic formatting configuration for vscode
Loading status checks…
2a2b898
@acoates-ms acoates-ms requested a review from microsoft/react-native-windows-write as a code owner Jun 20, 2019
@marlenecota
marlenecota approved these changes Jun 20, 2019
View changes
acoates-ms added 6 commits Jul 1, 2019
@acoates-ms
Replace tslint with eslint
6a5fb98
@acoates-ms
Format on save
20fc6b8
@acoates-ms
Fix a bunch of eslint errors
d14380d
@acoates-ms
merge master
Loading status checks…
a949bd4
@acoates-ms
Dont run lint on already build files
Loading status checks…
c8f91bb
@acoates-ms
lint now enforces LF to match community
Loading status checks…
0293192
@akrantz
Copy link
Collaborator

@akrantz akrantz commented Jul 1, 2019

@acoates-ms Does that mean that the .js/ts files would have LF only even on windows?
@akrantz
Copy link
Collaborator

@akrantz akrantz commented Jul 1, 2019

"lf" means normalize to LF on check-in, keeps as LF when checked out on Windows.
"crlf" means normalize to LF on check-in, convert to CRLF when checked out on Windows.

So my question is why do you want to keep LF only on Windows? In the past this has been problematic for editing (e.g. notepad) but it's gotten better. Is there something that REQUIRES keeping it LF on Windows? Is it because of lint rules?
@acoates-ms
Copy link
Collaborator Author

@acoates-ms acoates-ms commented Jul 1, 2019

Yes, the community linting rules require the files to be LF.
@ahimberg
ahimberg approved these changes Jul 1, 2019
View changes
@acoates-ms
Merge branch 'master' into formatting
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3d94178
@acoates-ms acoates-ms merged commit 388743e into master Jul 1, 2019
1 of 18 checks passed
1 of 18 checks passed
AzureDevOps - PR Build #20190701..8 failed
Details
AzureDevOps - PR (UWP PR ArmDebug) UWP PR ArmDebug failed
Details
AzureDevOps - PR (UWP PR ArmRelease) UWP PR ArmRelease failed
Details
AzureDevOps - PR (UWP PR PublicRNX86Debug) UWP PR PublicRNX86Debug failed
Details
AzureDevOps - PR (UWP PR X64Debug) UWP PR X64Debug failed
Details
AzureDevOps - PR (UWP PR X64Release) UWP PR X64Release failed
Details
AzureDevOps - PR (UWP PR X86Debug) UWP PR X86Debug failed
Details
AzureDevOps - PR (UWP PR X86Release) UWP PR X86Release failed
Details
AzureDevOps - PR (Verify react-native init) Verify react-native init failed
Details
AzureDevOps - PR (Windows Visual Studio with Win32 PR ArmDebug) Windows Visual Studio with Win32 PR ArmDebug failed
Details
AzureDevOps - PR (Windows Visual Studio with Win32 PR ArmRelease) Windows Visual Studio with Win32 PR ArmRelease failed
Details
AzureDevOps - PR (Windows Visual Studio with Win32 PR X64Debug) Windows Visual Studio with Win32 PR X64Debug failed
Details
AzureDevOps - PR (Windows Visual Studio with Win32 PR X64Release) Windows Visual Studio with Win32 PR X64Release failed
Details
AzureDevOps - PR (Windows Visual Studio with Win32 PR X86Debug) Windows Visual Studio with Win32 PR X86Debug failed
Details
AzureDevOps - PR (Windows Visual Studio with Win32 PR X86Release) Windows Visual Studio with Win32 PR X86Release failed
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
license/cla All CLA requirements met.
Details
@acoates-ms acoates-ms deleted the formatting branch Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@acoates-ms @akrantz @marlenecota @ahimberg
You can’t perform that action at this time.