Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTextInput's "clearButtonMode" does not seem to be implemented #4080
Comments
|
clearButtonMode is an iOS only prop which is likely why we didn't get to it so far. However, this is likely a supported prop in Windows/XAML and we should be able to plumb it through. |
harinikmsft
added
Area: TextInput
API: Completion
and removed
Needs: Triage 
|
+1 for this issue. Our app needs to disable TextInput's built-in clear button in lieu of a 'fancier' clear button for a specific scenario. |
|
Another note here; while the clearButtonMode is an iOS-only property, the default behavior on both Android and iOS is to never display a 'clear' or 'delete' button (eg. clearButtonMode='never') That makes RNW an outlier. Anyone making sophisticated cross-platform apps will need to workaround this problem on RNW for a very basic element. |
|
Here's an example... |
|
Note that there isn't a property on TextBox to control showing/hiding this button. We may be able to use VisualTreeHelper to find/hide it, just need to confirm this will work reliably across all versions we support. |
Environment
If you are using latest version:
react-native -v: 0.60.6react-native run-windows --info:System:
OS: Windows 10 10.0.18363
CPU: (12) x64 Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz
Memory: 18.01 GB / 31.84 GB
Binaries:
Node: 10.15.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.21.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.13.7 - C:\Program Files\nodejs\npm.CMD
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.6 => 0.60.6
react-native-windows: 0.60.0-vnext.133 => 0.60.0-vnext.133
rnpm-plugin-windows: 0.3.5 => 0.3.5
Installed UWP SDKs:
10.0.14393.0
10.0.15063.0
10.0.16299.0
10.0.17134.0
10.0.17749.0
10.0.17763.0
10.0.18362.0
Then, specify:
Steps to Reproduce
Create a project using react-native-windows that includes a single-line TextInput. Provide the prop "clearButtonMode" and set it to "never".
Expected Behavior
The TextInput should never display a clear button.
Actual Behavior
The TextInput displays a clear button when the TextInput is not empty and is in focus.