Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCSharpDecompiler.DecompileWholeModuleAsSingleFile() name confusing #1833
Labels
Comments
|
Well if you think about the compiler's input, each syntax tree is a file. |
|
Hmm OK, I see, so "AsSingleFile" refers to the input, not the output. Knowing the context now makes it clear and my I'm not a native English speaker but for me, this wording is still strange and initially, I dismissed this method since I didn't want to receive a file. However, I don't really have a better suggestion, so if you'd like then please close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd suggest renaming
CSharpDecompiler.DecompileWholeModuleAsSingleFile()toDecompileWholeModuleAsSingleSyntaxTree()as in my understanding it's not really doing anything with a single file. The documentation on the method reinforces this: "Decompiles the whole module into a single syntax tree.".Am I missing something?