Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fixed style bugs on tags | #330 #477
Closed
Conversation
|
Fixed in #487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Fix style bugs on tags:
Prevent word-break on
CN,KRand other characters.Add
maxLengthto prevent "immortal" tags. (conflicts with the new update)Addresses Issue #330
c5bbe8a:
Max length on tagsI setmaxLengthto25after testingLLLLLL....,TTTTTT....wide letters on it and came to a conclusion to set it to25. This is a possible fix to the problem of immortal tags.Personally, I think this is a good move to prevent long tag abuse (although I know it's the user's decision).