The Wayback Machine - https://web.archive.org/web/20200603210319/https://github.com/radareorg/cutter/issues/2161
Skip to content

/ cutter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that search is in progress #2161

Open
ITAYC0HEN opened this issue Apr 18, 2020 · 4 comments
Open

Indicate that search is in progress #2161

ITAYC0HEN opened this issue Apr 18, 2020 · 4 comments
Labels
UI good first issue

Comments

@ITAYC0HEN
Copy link
Member

@ITAYC0HEN ITAYC0HEN commented Apr 18, 2020

Describe the solution you'd like
When searching in huge files, there's is no clear indication that Cutter is searching (except freeze).

In addition, when search finishes very fast (say, in tiny binary) and no results found, then there is no indication for this, and it feels like clicking the button does nothing

search_no_response

  • Add indication to the Search widget that a search is currently in progress
  • Add an indication that no results were found
@Surendrajat
Copy link
Contributor

@Surendrajat Surendrajat commented May 30, 2020 •
edited

@ITAYC0HEN I tried to do it this way:
Append a Data item in SearchDescription saying "Searching" or "No result found!".
While the later worked fine, the first one didn't as I added it before beginResetModel(). Any suggestions?
@karliss
Copy link
Contributor

@karliss karliss commented May 30, 2020

How about disabling the Search button while it's in progress?
@karliss
Copy link
Contributor

@karliss karliss commented May 30, 2020

I don't this issue can be properly implemented before the big async refactoring. @ITAYC0HEN might have rushed it with marking this as good first issue.
@ITAYC0HEN
Copy link
Member Author

@ITAYC0HEN ITAYC0HEN commented May 30, 2020

I will clarify what I am thinking ->

  1. User clicks the Search button
  2. Change button's text to "Searching..."
  3. Disable button
  4. If needed, force redraw of the button
  5. Perform search
  6. If results found, shown on the table. If results were not found, show the "No results found" indicator
  7. Return the button's text to "Search"
  8. Enable the button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI good first issue
3 participants
@karliss @Surendrajat @ITAYC0HEN
You can’t perform that action at this time.