The Wayback Machine - https://web.archive.org/web/20200530145733/https://github.com/mac-cain13/R.swift/issues/409
Skip to content

/ R.swift

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewController placeholder (Storyboard reference) in Storyboard with implicit module is not supported #409

Open
seasox opened this issue May 18, 2018 · 3 comments
Open

ViewController placeholder (Storyboard reference) in Storyboard with implicit module is not supported #409

seasox opened this issue May 18, 2018 · 3 comments
Labels
difficulty: easy type: issue

Comments

@seasox
Copy link

@seasox seasox commented May 18, 2018

A <viewControllerPlaceholder> in a storyboard without explicit storyboard causes
warning: [R.swift] Destination view controller with id 1QH-mG-fNL for segue ShowStatistic in StatisticViewController not found in storyboard Statistics. Is this storyboard corrupt?

Explicitly setting storyboardName on <viewControllerPlaceholder> fixes this:

-  <viewControllerPlaceholder referencedIdentifier="StatisticViewController" id="1QH-mG-fNL" sceneMemberID="viewController"/>
+  <viewControllerPlaceholder storyboardName="Statistics"  referencedIdentifier="StatisticViewController" id="1QH-mG-fNL" sceneMemberID="viewController"/>
@mac-cain13
Copy link
Owner

@mac-cain13 mac-cain13 commented Jun 7, 2018

So if you ignore the R.swift warning and run the project without giving the viewControllerPlaceholder and storyboardName, does it work? Can you perform a segue towards that viewControllerPlaceholder?
@seasox
Copy link
Author

@seasox seasox commented Jun 18, 2018

R.swift will skip the offending segue if storyboardName is not set. Segues from XIB work as intended without storyboardName set, so storyboardName does not seem to be necessary to me.
@mac-cain13
Copy link
Owner

@mac-cain13 mac-cain13 commented Nov 28, 2018

Okay so, not filling in the storyboard name would mean you use a storyboard reference to reference to the current storyboard you're in. Also not filling the Referenced ID is allowed, meaning you want the initial controller.

So I think it could indeed be considered a bug that a segue to an "empty" storyboard reference is ignored. We should fallback to the same defaults as Apple does in UIKit.
@mac-cain13 mac-cain13 changed the title ViewController placeholder in Storyboard with implicit module causes "Destination view controller not found" warning ViewController placeholder (Storyboard reference) in Storyboard with implicit module is not supported Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy type: issue
2 participants
@mac-cain13 @seasox
You can’t perform that action at this time.