The Wayback Machine - https://web.archive.org/web/20201205051045/https://github.com/dvf/blockchain/pull/130
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dotnetcore implementation #130

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@ArminNaish
Copy link

@ArminNaish ArminNaish commented Oct 7, 2018

Hey there, I implemented your blockchain sample in dotnet core (runs on linux, mac and windows). Check out the source code if you like. Great blog post by the way!

@@ -0,0 +1,46 @@
{
// Use IntelliSense to find out which attributes exist for C# debugging

This comment has been minimized.

@jeffrade

jeffrade Oct 27, 2018

Commenting // isn't valid JSON.

@jeffrade
Copy link

@jeffrade jeffrade commented Oct 27, 2018

I would add a .gitignore file. Looks like a lot of files are committed that shouldn't be. For example, I wouldn't expect the dotnetcore/BlockChain.Tests/bin folder to be committed.

@@ -0,0 +1,14 @@
/home/armin/code/Blockchain/csharp/Blockchain/bin/Debug/netcoreapp2.1/Blockchain.deps.json

This comment has been minimized.

@jeffrade

jeffrade Oct 27, 2018

Pretty sure this file need to be committed.

@@ -0,0 +1 @@
f959d93c94861c8f26962e03a52ddb0c60ce0617

This comment has been minimized.

@jeffrade

jeffrade Oct 27, 2018

None of these *.cache files need to be here.

@jeffrade
Copy link

@jeffrade jeffrade commented Oct 27, 2018

@ArminNaish I would clean up a lot of this PR and only commit the absolute bare minimum for someone else to build and run from source. Utilize a .gitignore file.

@ArminNaish
Copy link
Author

@ArminNaish ArminNaish commented Nov 8, 2018

@jeffrade thank you very much for your code review. I Removed obsolete files by adding a .gitignore file. Sorry it took me so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.