The Wayback Machine - https://web.archive.org/web/20200523161957/https://github.com/FormidableLabs/react-game-kit/issues/65
Skip to content

/ react-game-kit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing Loop div element with Fragment #65

Open
hasparus opened this issue May 17, 2018 · 0 comments
Open

Replacing Loop div element with Fragment #65

hasparus opened this issue May 17, 2018 · 0 comments

Comments

@hasparus
Copy link

@hasparus hasparus commented May 17, 2018

react-game-kit/src/components/loop.js

Lines 38 to 48 in e9797f4

const defaultStyles = {
height: '100%',
width: '100%',
};
const styles = { ...defaultStyles, ...this.props.style };
return (
<div style={styles}>
{this.props.children}
</div>
);
}

Since Loop doesn't say anything about rendering, maybe we could change this div to React.Fragment?
I'm happy to make a PR if it's okay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@hasparus
You can’t perform that action at this time.