The Wayback Machine - https://web.archive.org/web/20201207185313/https://github.com/GoogleCloudPlatform/DataflowJavaSDK/issues/586
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataflowPathValidator.verifyPathIsAccessible should throw checked exception, not runtime exception #586

Open
elharo opened this issue Jul 5, 2017 · 0 comments

Comments

@elharo
Copy link

@elharo elharo commented Jul 5, 2017

still digging into exactly why this happens, but meanwhile this should be a checked exception, probably some kind of IOException. This is an external condition, not a bug in the program itself. so an IllegalArgumentException is inappropriate.

Caused by: java.lang.IllegalArgumentException: Output path does not exist or is not writeable: gs://tester
	at com.google.cloud.dataflow.sdk.repackaged.com.google.common.base.Preconditions.checkArgument(Preconditions.java:146)
	at com.google.cloud.dataflow.sdk.util.DataflowPathValidator.verifyPathIsAccessible(DataflowPathValidator.java:80)
	at com.google.cloud.dataflow.sdk.util.DataflowPathValidator.validateOutputFilePrefixSupported(DataflowPathValidator.java:63)
	at com.google.cloud.dataflow.sdk.runners.DataflowPipelineRunner.fromOptions(DataflowPipelineRunner.java:274)
	at com.google.cloud.dataflow.sdk.runners.BlockingDataflowPipelineRunner.fromOptions(BlockingDataflowPipelineRunner.java:82)
	... 9 more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.