The Wayback Machine - https://web.archive.org/web/20200530124528/https://github.com/storybookjs/storybook/issues/8541
Skip to content

/ storybook

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isFullscreen: false option not working #8541

Open
lancevalour opened this issue Oct 23, 2019 · 9 comments
Open

isFullscreen: false option not working #8541

lancevalour opened this issue Oct 23, 2019 · 9 comments
Labels
bug good first issue help wanted ui

Comments

@lancevalour
Copy link

@lancevalour lancevalour commented Oct 23, 2019

Describe the bug
In the config.js addParameters function, if I set isFullscreen: true and open the webpage, it is fullscreen on startup. But if I set isFullscreen: false and open the webpage again, it is still full-screen on startup.

To Reproduce

  1. Set isFullscreen: true, open the webpage,
  2. Close the webpage or stop the server
  3. Set isFullscreen: false, open the webpage

Expected behavior
I should see storybook not in full-screen mode

System:

Environment Info:

  System:
    OS: Windows 10
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 10.15.0 - C:\Program Files\nodejs\node.EXE
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
@shuklajay117
Copy link

@shuklajay117 shuklajay117 commented Nov 5, 2019

I can work on this issue. Can anyone guide me please?
I'm going to contribute here first time.
@hobroker
Copy link
Contributor

@hobroker hobroker commented Nov 10, 2019

@shilman, that's related to #5857, isn't it?
@ahmedkhan1
Copy link

@ahmedkhan1 ahmedkhan1 commented Apr 20, 2020 •
edited

Is this issue this open? i wish to work on it.
@shilman
Copy link
Member

@shilman shilman commented Apr 20, 2020

@ahmedkhan1 yes please!
@aditya237
Copy link

@aditya237 aditya237 commented May 9, 2020

I'm a first timer wanna contribute is it still available
i'll do my best to remove the bug
@zootechdrum
Copy link

@zootechdrum zootechdrum commented May 27, 2020

Hello, is anyone working on this?
@shilman
Copy link
Member

@shilman shilman commented May 27, 2020

not that i know of
@zootechdrum
Copy link

@zootechdrum zootechdrum commented May 27, 2020

Great, I will take this on. I have downloaded storybook now and messing around with the features. I will try and reproduce the error on my machine. I am running on a mac, hopefully this isn't just a windows thing.
@zootechdrum
Copy link

@zootechdrum zootechdrum commented May 27, 2020

Interesting, I can't reproduce this error. I am running on a Mac. When I add the manager.js file and go from true to false after closing the window I see the that side nav is visible. When set to true the side panel is not visible.
Screen Shot 2020-05-26 at 9 42 59 PM
Screen Shot 2020-05-26 at 9 43 17 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue help wanted ui
7 participants
@shilman @hobroker @shuklajay117 @lancevalour @ahmedkhan1 @zootechdrum @aditya237
You can’t perform that action at this time.