Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd EdDSA/ed25519 ISignatureVerifier #62
Comments
|
There's an ed25519 library compliant with .NET Standard here: https://github.com/Deadpikle/Chaos.NaCl (forked from https://github.com/CodesInChaos/Chaos.NaCl). It's in the public domain. If that were to be referenced from our project, implementation would be fairly straight forward. |
|
@Deadpikle If this is easy, do you mind doing it? DSA-SHA1 signatures haven't been secure for many years, and it would be nice to have a secure option Edit: I did try to do it myself, but got lost in the weeds |
|
@Bren2010 I will try to do it within the next week if I can! |
|
Just wanted to chime in, I added Ed25519 support the to AppCastGenerator last night. DSACryptoServiceProvider is a thin windows only wrapper. Can't generate keys on linux / mac. I can implement ISignatureVerifier for Ed25519 this weekend, we can switch the project over to Ed25519 if you want. Let me know. |
|
I was planning to work on it this Sunday if I could. I don't mind if you open a PR for it, but there's no rush. I'll check again Sunday whenever-I-get-to-it to see if you've done it already; if not, I'll work on it. (Also planning to look at your other PR on Sunday.) I am planning/will want unit tests for Ed25519 stuff. We'll also need a new/updated command line tool for verifying/checking/generating Ed25519 keys. I really appreciate your help, here. |
|
https://github.com/mphill/NetSparkle I didn't do a PR yet, but I already merged the command line checker into the app cast app and created Ed25519Checker. These are the new options:
|
|
@Bren2010 Ed25519 support is now on |
|
Thank you!! |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

See vslavik/winsparkle#187 and changes in Sparkle. Would need to create a new class that implements
ISignatureVerifier.