The Wayback Machine - https://web.archive.org/web/20201208121351/https://github.com/nexB/scancode-toolkit/issues/1983
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license detection rules for https://licensebuttons.net/ #1983

Closed
pombredanne opened this issue Mar 25, 2020 · 3 comments
Closed

Add license detection rules for https://licensebuttons.net/ #1983

pombredanne opened this issue Mar 25, 2020 · 3 comments

Comments

@pombredanne
Copy link
Member

@pombredanne pombredanne commented Mar 25, 2020

Short Description

https://licensebuttons.net/ contains several buttons to CC licenses that are found as links often enough.
For instance https://licensebuttons.net/p/80x15.png or https://licensebuttons.net/l/GPL/2.0/88x62.png
Each such URL should be added as a license detection rule

Possible Labels

  • new feature

Select Category

  • Enhancement [x]
  • Add License/Copyright [x]
  • Scan Feature []
  • Packaging []
  • Documentation []
  • Expand Support []
  • Other []
@MankaranSingh
Copy link
Contributor

@MankaranSingh MankaranSingh commented Mar 27, 2020

All these would be considered as 'license reference', right ?

@MankaranSingh
Copy link
Contributor

@MankaranSingh MankaranSingh commented Mar 27, 2020

I tried to add this as a license rule "https://licensebuttons.net/l/GPL/2.0/{{88x62.png}}" since they may add new resolutions or formats later. But this doesn't seem to work when i change the resolution or format in test file.

Also, See this https://licensebuttons.net/l/by-nc-nd/2.5/
It has a lot of sub folders according to region, so should i just add "https://licensebuttons.net/l/by-nc-nd/2.5/" as a licence rule (which also solves the above problem) ?

@pombredanne
Copy link
Member Author

@pombredanne pombredanne commented Mar 27, 2020

All these would be considered as 'license reference', right ?

Yes these are references...

Also, there is no such thing as curly braces to abstract parts such as in {{}}
Instead of https://licensebuttons.net/l/GPL/2.0/{{88x62.png}} just craft eventually two rules:

  • https://licensebuttons.net/l/GPL/2.0/88x62.png
  • https://licensebuttons.net/l/GPL/2.0/

Also, See this https://licensebuttons.net/l/by-nc-nd/2.5/
It has a lot of sub folders according to region, so should i just add "https://licensebuttons.net/l/by-nc-nd/2.5/" as a licence rule (which also solves the above problem) ?

yes that's an excellent approach! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.