The Wayback Machine - https://web.archive.org/web/20200913003534/https://github.com/pure-c/purec/issues/12
Skip to content

/ purec

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run against all passing tests in PureScript compiler test suite #12

Open
felixSchl opened this issue Sep 3, 2018 · 7 comments
Open

Run against all passing tests in PureScript compiler test suite #12

felixSchl opened this issue Sep 3, 2018 · 7 comments
Labels
good first issue help wanted priority

Comments

@felixSchl
Copy link
Collaborator

@felixSchl felixSchl commented Sep 3, 2018 •
edited

All of these tests should eventually pass using this backend: https://github.com/purescript/purescript/tree/master/tests/purs/passing.

The directory structure is set up such that every (NAME).purs file is a test with additional supporting modules optionally residing in a folder named (NAME)/ in the same directory.

The logic for this already exists for the most part: https://github.com/felixSchl/purescript-c/blob/5ccdd0584d856584259096eadd11d316375f476d/test/Main.purs#L49-L57.

  • Resolve dependencies (do all tests just rely on prelude?)
  • Compile Makefiles (#13)
  • Generate test suite using purescript-spec (each test case should become an it block)
@felixSchl felixSchl changed the title Run against all passing test in PureScript compiler test suite Run against all passing tests in PureScript compiler test suite Sep 4, 2018
@felixSchl felixSchl mentioned this issue Sep 5, 2018
Closed
felixSchl pushed a commit that referenced this issue Sep 5, 2018
Felix Schlitter
Fix variables being redefined (#12)
66ceed1
@felixSchl
Copy link
Collaborator Author

@felixSchl felixSchl commented Sep 5, 2018

Everything's set up now to work through the tests fixing anything that comes up. The biggest problem now is not having implemented the FFI of many of the dependencies. This is where fun becomes work and contributions would be very welcomed.
felixSchl added a commit that referenced this issue Sep 6, 2018
@felixSchl
Add shell script to print bower dep graph
d058cbd 
Useful to plot the dependency graph of a package in order to plan
out implementing the C FFI of common packages (at least enough of
them to complete #12).
@felixSchl
Copy link
Collaborator Author

@felixSchl felixSchl commented Sep 6, 2018 •
edited

deps

  • #f03c15 todo
  • #c5f015 done
This was referenced Sep 22, 2018
Closed
Closed
felixSchl pushed a commit that referenced this issue Sep 27, 2018
Felix Schlitter
Mark more packages as completed for #12
e33505d
@felixSchl felixSchl mentioned this issue Oct 3, 2018
Open
@felixSchl
Copy link
Collaborator Author

@felixSchl felixSchl commented Oct 3, 2018

We're starting to look really good. @Lupino do you feel up to doing more? I am thinking of taking a stab at purescript-st next.
This was referenced Oct 3, 2018
Open
Closed
Closed
Open
Open
Open
Closed
@felixSchl
Copy link
Collaborator Author

@felixSchl felixSchl commented Oct 3, 2018

I've created a number of issues and an encompassing project. If you want to work on any of the issues please make sure it's not already assigned.
This was referenced Oct 8, 2018
Merged
Closed
@felixSchl
Copy link
Collaborator Author

@felixSchl felixSchl commented Oct 11, 2018

Yay, we're 239/266 tests passing! A few sigsegvs here (likely stack overflows) and a few sigabrt there (likely failed asserts), a missing implementation for ObjectUpdate, a few missing FFIs for tests themselves, as well as a missing implementations for purescript-arrays (#36), purescript-strings (#34), and we'll be there before we know it!
@felixSchl felixSchl mentioned this issue Oct 18, 2018
Closed
@felixSchl
Copy link
Collaborator Author

@felixSchl felixSchl commented Oct 19, 2018

We're at 255/266 with @Lupino's work on purescript-arrays. Almost there! :)
@felixSchl
Copy link
Collaborator Author

@felixSchl felixSchl commented Oct 22, 2018

We're at 256/266 as of 993d1fd.

What's next: I think the missing FFI tests will fall relatively quickly, but there's some corefn parsing issues which might cause a larger hold up, for example: paulyoung/purescript-corefn#57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted priority
1 participant
@felixSchl
You can’t perform that action at this time.