The Wayback Machine - https://web.archive.org/web/20210121045357/https://github.com/roots/sage/pull/2138
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage 10 #2138

Merged
merged 145 commits into from May 10, 2020
Merged

Sage 10 #2138

merged 145 commits into from May 10, 2020

Conversation

@QWp6t
Copy link
Member

@QWp6t QWp6t commented Dec 29, 2018

There's a new version of Sage in the pipeline. The most significant change is the introduction of Acorn. I'll release more information about Acorn as it nears completion.

TODO

Sage 10 and Acorn are both still works in progress so you should definitely not start any projects with them in their current state unless you're willing to do an inordinate amount of debugging and go through the hassle of keeping up with updates as we push them.

Resolves #2102

There's a new version of Sage in the pipeline. The most significant change is the introduction of Acorn. I'll release more information about Acorn as it nears completion.

TODO

- [ ] Restructure templates (@retlehs)
- [ ] Code splitting (@austinpray, @QWp6t, @swalkinshaw)
- [ ] WooCommerce compatibility (@QWp6t, @retlehs)
- [ ] API for build process (possibly extend Laravel Mix) (@QWp6t, @austinpray)
- [ ] Acorn - roots/acorn#1 (@QWp6t)
- [ ] Documentation

Sage 10 and Acorn are both still works in progress so you should definitely not start any projects with them in their current state unless you're willing to do an inordinate amount of debugging and go through the hassle of keeping up with updates as we push them.
@QWp6t QWp6t added this to the 10.0.0 milestone Dec 29, 2018
@QWp6t QWp6t changed the title Sage 10 (#2122) Sage 10 Dec 29, 2018
@ThatGuySam
Copy link

@ThatGuySam ThatGuySam commented Jan 23, 2019

This is cool! Laravel Mix is my #1 most wanted feature out of this project right now.

@azdanov azdanov mentioned this pull request Jan 25, 2019
5 of 6 tasks complete
retlehs and others added 3 commits Apr 18, 2019
Enable preflight by default
Bump version to 10.0.0 in package.json and style.css
Change PHP requirement to 7.1.3
Upgrade roots/sage-installer
Remove deprecated qwp6t/acorn repository from composer.json
Add some sane optimizations to composer.json
Remove excessive linebreaks from helpers.php
Make config linebreaking uniform
Add missing space to ! conditionals to stay consistent with PSR-1/2
Update the file structure in README.md and add the new sponsor
Revert to shorthand @php()
Add aside markup to sidebar and wrap it in @hasSection
Add a document wrapper
Add ARIA roles to the document, main, aside, header, nav, and footer wrappers
Change entry-meta conditional in content-search.blade.php to an @includeWhen
Add some sane linebreaks throughout the views and codebase to increase readability
Add docblocks to the example Title.php composer
@Log1x
Copy link
Member

@Log1x Log1x commented May 1, 2019

I did some clean up/fixes for the Sage 10 branch in #2171. Opinions welcome.

As far as Mix goes, I've always been vocal about it in the past, so I'm more than willing to get the train rolling on that.

I guess the main question is, what is being specifically desired that is outside of the scope of Mix out of the box? All I can think of is stylelint and ESLint both of which have packages available (or we can roll our own laravel-mix-linting to handle both).

Outside of the above, the only change that would be necessary after the fact would be adding the leading slash when fetching the asset in Acorn's Manifest class.

Log1x and others added 16 commits May 1, 2019
Remove roots/wp-blade-check until we decide on where to put it
Only enable preflight when not in production
Sage 10 Cleanup
Clean up and refactor starter styles
Remove autoload from styles/scripts
Remove $ import on customizer.js as Mix autoload will handle that
Fix conditional on comments.blade.php
Bump PHP version to 7.1.3 on Travis
Remove unnecessary fields in package.json as it will never be published
Rename main.css/main.js to app.css/app.js
Automatically remove Blade cache when theme is activated, changed, or removed
Fix typo in lint:scripts
Restore double quotes in list:styles
Add missing space after ! in body_class filter
Change add_editor_style() back to app.css for now
Add missing finalize() to about.js
Uncomment Bootstrap Navbar Fix (although I do not know if its still needed)
Add linebreak to li in comments.blade.php
Bump Node.js version in README
Restore my initial .editorconfig change
Make app.js comments uniform
Remove sage-installer (will be replaced)
Bump dependencies for good measure
Move Sage 10 to Laravel Mix
This lets us run related scripts together pretty easily since we can
use glob patterns (e.g. `lint:*` — `**` is supported too). You can
either run scripts sequentially with `run-s` or in parallel with
`run-p`.

See: https://github.com/mysticatea/npm-run-all
This way lint issues for the scripts doesn’t block the styles from being
linted.
* Break up `build:production`
* Refine `start` script to call `build` but using `--watch`
  * Since the base command is the same, this makes it easier to
    maintain.
* Use run-s for `test` script for consistency.
kellymears and others added 26 commits Dec 7, 2019
* adds alternate button style and super basic starter css

* Adds transition variable

* Add bootstrap max-width to editor-styles

* updates button scss, editor wrapper scss, and registration

* rename is-style-ghost to is-style-outline

* simplify structure and cleanup css

* Protect Ben Word's typographic holdings

* Remove scoping from .has-xyz-color classes

* Restore scss partial import structure

* rename partials, move color util, apply bootstrap font

* alphabetical selectors ¯\_(ツ)_/¯
Bumps [stylelint](https://github.com/stylelint/stylelint) from 11.1.1 to 12.0.0.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md)
- [Commits](stylelint/stylelint@11.1.1...12.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [squizlabs/php_codesniffer](https://github.com/squizlabs/PHP_CodeSniffer) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/squizlabs/PHP_CodeSniffer/releases)
- [Commits](squizlabs/PHP_CodeSniffer@3.5.2...3.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Update theme structure + files in README
feat(stylelint): Set `at-rule-empty-line-before` to `null` to allow sane seperation of imports
* fix(templates): Move the document wrapper from app.blade.php to index.php to fix hook run sequence (See: #2123)
* feat(mix): Add purgecss-with-wordpress whitelists by default
* chore(docblocks): Remove copyright/license from PHP docblocks
* chore(babel): Remove unused dynamic import plugin until Webpack 5
* chore(babel): Remove unused .babelrc
* chore(deps): Bump dependencies
* enhance(acorn): Update to Laravel 7.x
* enhance(blade): Convert existing alert component to a new View Component
* chore(deps): Bump minimum PHP version to 7.2.5
* chore(deps): Bump dependencies
* chore(configs): Clean up configs
* BREAKING(config): Bump configs to support Laravel 7.x
* BREAKING(components): @Alert() has been replaced with <x-alert ...>
* BREAKING(composers): View co
…yle headers. Bump WordPress requirement to v5.4 (#2409)
* enhance(functions): Make functions.php pretty
* fix(component): Fix improper use of translation on the Alert component
* enhance(component): Add `$slot` fallback ternary to the Alert component view
* chore(component): Move Alert component message to a slot by default to properly pass the translated string.
* chore(component): Properly set default values for Alert
* chore(deps): Bump dependencies
* chore(theme): Fix required PHP version in style.css
Bumps [roots/acorn](https://github.com/roots/acorn) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/roots/acorn/releases)
- [Commits](roots/acorn@v1.0.2...v1.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [roots/acorn](https://github.com/roots/acorn) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/roots/acorn/releases)
- [Commits](roots/acorn@v1.0.3...v1.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.2.1 to 13.3.0.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md)
- [Commits](stylelint/stylelint@13.2.1...13.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [roots/acorn](https://github.com/roots/acorn) from 1.0.4 to 1.0.6.
- [Release notes](https://github.com/roots/acorn/releases)
- [Commits](roots/acorn@v1.0.4...v1.0.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
…5.0 (#2448)

Bumps [@wordpress/dependency-extraction-webpack-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/dependency-extraction-webpack-plugin) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/master/packages/dependency-extraction-webpack-plugin/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/dependency-extraction-webpack-plugin@2.5.0/packages/dependency-extraction-webpack-plugin)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [@wordpress/babel-preset-default](https://github.com/WordPress/gutenberg/tree/HEAD/packages/babel-preset-default) from 4.11.0 to 4.12.1.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/master/changelog.txt)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/babel-preset-default@4.12.1/packages/babel-preset-default)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [squizlabs/php_codesniffer](https://github.com/squizlabs/PHP_CodeSniffer) from 3.5.4 to 3.5.5.
- [Release notes](https://github.com/squizlabs/PHP_CodeSniffer/releases)
- [Commits](squizlabs/PHP_CodeSniffer@3.5.4...3.5.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [laravel-mix-copy-watched](https://github.com/dsktschy/laravel-mix-copy-watched) from 2.2.3 to 2.2.4.
- [Release notes](https://github.com/dsktschy/laravel-mix-copy-watched/releases)
- [Commits](dsktschy/laravel-mix-copy-watched@v2.2.3...v2.2.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [jquery](https://github.com/jquery/jquery) from 3.4.1 to 3.5.0.
- [Release notes](https://github.com/jquery/jquery/releases)
- [Commits](jquery/jquery@3.4.1...3.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.3.0 to 13.3.3.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md)
- [Commits](stylelint/stylelint@13.3.0...13.3.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@retlehs retlehs merged commit 2c54799 into master May 10, 2020
1 check passed
1 check passed
build Workflow: build
Details
oxyc added a commit to generoi/sage that referenced this pull request May 28, 2020
* roots/master:
  Update sponsors [ci skip]
  Update CHANGELOG [ci skip]
  Bump bootstrap from 4.4.1 to 4.5.0 (roots#2467)
  Bump @wordpress/babel-preset-default from 4.12.1 to 4.13.0 (roots#2468)
  Bump roots/acorn from 1.0.6 to 1.0.8 (roots#2469)
  Update README [ci skip]
  Sage 10 (roots#2138)
  Update sponsors
  Update sponsors [ci skip]
  Update sponsors [ci skip]
  Update sponsors [ci skip]
  Update sponsors [ci skip]
  Update sponsors [ci skip]
  Fix issue-close-message
  Add issue closer github action
  Update sponsors [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.