Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
No mention of how to use eq/order in narrative docs #598
Comments
|
Changing src/ims/application/_main.py:74:2: error: No overload variant of "attrs" matches argument types "bool", "bool", "bool", "bool" [call-overload]
@attrs(frozen=True, auto_attribs=True, kw_only=True, eq=False)
^
src/ims/application/_main.py:74:2: note: Possible overload variants:
src/ims/application/_main.py:74:2: note: def [_C <: type] attrs(maybe_cls: _C, these: Optional[Dict[str, Any]] = ..., repr_ns: Optional[str] = ..., repr: bool = ..., cmp: bool = ..., hash: Optional[bool] = ..., init: bool = ..., slots: bool = ..., frozen: bool = ..., weakref_slot: bool = ..., str: bool = ..., auto_attribs: bool = ..., kw_only: bool = ..., cache_hash: bool = ..., auto_exc: bool = ...) -> _C
src/ims/application/_main.py:74:2: note: def attrs(maybe_cls: None = ..., these: Optional[Dict[str, Any]] = ..., repr_ns: Optional[str] = ..., repr: bool = ..., cmp: bool = ..., hash: Optional[bool] = ..., init: bool = ..., slots: bool = ..., frozen: bool = ..., weakref_slot: bool = ..., str: bool = ..., auto_attribs: bool = ..., kw_only: bool = ..., cache_hash: bool = ..., auto_exc: bool = ...) -> Callable[[_C], _C]
Found 14 errors in 12 files (checked 1 source file) |
|
Hi. There are 2 issues here.
I don't know what to do about 2. We could update the stubs or we could delete them. Anybody have opinions? |
|
By stubs you mean stubs in typeshed? Is that for us to decide? |
|
@euresti For #2, should it be enough to simply install wsanchez$ ./.tox/mypy/bin/pip freeze | grep '^attrs'
attrs==19.1.0…but I still get the same errors. And it's fixed if I update to Leaving this comment here for the next developer's benefit. |
|
I think it's for us to decide. We decided to give me permission to add the stubs to attrs. :)
|
I'm getting a new handy error from
mypy:src/ims/application/_main.py:74:2: error: cmp is deprecated, use eq and order [misc]In order to make sure I'm using those correctly, I went to
attrs.organd looked for some documentation on these new options, but I see no mention of either of theeqororderoptions, except for some mentions ofeqin the section on hashing.With a deprecation notice like this, a link to some documentation for how to fix your code would be very helpful.