Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcmd/torrent: -testPeer no longer accepts string names #395
Comments
|
This is due to a change I made in tagflag. I found that resolving hostnames was stalling argument parsing, which led to really weird behavior sometimes. I think the solution is to accept a string if you want to resolve it manually, or if you prefer the old behaviour, downgrade tagflag slightly or propose a better way to handle this. |
|
Do you have any more feedback on this @yarikk? Can I close this? |
|
While it would be nice to have this consistent with what the net.Dial would accept, it's definitely not critical. |
|
Should be fixed, let me know if you have any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since recently,
Not sure if the change is in right direction: since BEP3 allows "An optional parameter giving the IP (or dns name) which this peer is at. " in tracker announcements, shouldn't test peers allow that too?