The Wayback Machine - https://web.archive.org/web/20200526195405/https://github.com/goldbergyoni/nodebestpractices/pull/687
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestion to use OpenAPI/Swagger-spec based validation #687

Open
wants to merge 3 commits into
base: master
from

Conversation

@kibertoad
Copy link

kibertoad commented May 15, 2020

Full disclosure - I am a contributor to the second mentioned library. If you feel that this constitutes a conflict of interest and prefer reference to said library to be removed, I would be happy to do so (but it provides support for koa and fastify, while the most popular express option does not).

@goldbergyoni
Copy link
Owner

goldbergyoni commented May 24, 2020

@kibertoad Welcome aboard, glad to have you here 👋

This part indeed should get enriched & modernized not only with Open-API validators but also with class-validator (popular TS decoration based validation).

About the specific package recommendations, did you see this part in our writing-guideliness.md? Didn't check the libs that you mentioned, do they qualify?

image
https://github.com/goldbergyoni/nodebestpractices/blob/master/.operations/writing-guidelines.md

@kibertoad
Copy link
Author

kibertoad commented May 24, 2020

I can look into class-based validators and create a separate PR for that.

I've checked with npm, those two libraries are the ones with the most downloads, and qualify on download and update frequency cadence as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.