Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upThe Dash docset URL is incorrect #1188
Closed
Labels
Comments
|
Thanks - looks like this has never worked when there's a path component in the URL (Yikes). edit: Actually it's not that bad: |
|
Thanks for looking into this. I'll just wait until this is properly fixed. The Dash link is not important for me and my current workaround works fine for now. |
Merged
|
Fixed in master via #1197. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jazzy config: https://github.com/sindresorhus/KeyboardShortcuts/blob/a1550ae2c7fc96e07648cc045855eb89ab621b87/.jazzy.yml
I think it's because I upload the docs to a sub-path: https://sindresorhus.com/KeyboardShortcuts/ (not visible as I'm hiding it for now with JavaScript)
The Dash feed URL ends up being
dash-feed://https%3A%2F%2Fsindresorhus%2Ecom%2Fdocsets%2FKeyboardShortcuts%2Exml, where the URL decoded ishttps://sindresorhus.com/docsets/KeyboardShortcuts.xml, while it should have beenhttps://sindresorhus.com/KeyboardShortcuts/docsets/KeyboardShortcuts.xml. The URL in the XML is also incorrect.I tried setting
dash_url: https://sindresorhus.com/KeyboardShortcuts/docsets/KeyboardShortcuts.xml, but that didn't help.