The Wayback Machine - https://web.archive.org/web/20200912060740/https://github.com/psf/requests/pull/5232
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout as a default attribute for Session objects #5232

Open
wants to merge 1 commit into
base: master
from

Conversation

@ofek
Copy link
Contributor

ofek commented Oct 17, 2019

We encountered a bug today wherein we mistakenly assumed it was already supported as an attribute like all the other kwargs, DataDog/integrations-core#4811

@ofek ofek force-pushed the ofek:session-timeout branch from c54d81b to a505867 Oct 17, 2019
@ofek
Copy link
Contributor Author

ofek commented Oct 17, 2019

@Lukasa @kennethreitz @nateprewitt Hello there! After opening this I came across #3341

Does that decision (from way back then) still remain true today? As it is, the behavior is not very user-friendly and is entirely unexpected, hence the reason so many people keep opening the same PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.