The Wayback Machine - https://web.archive.org/web/20201016113226/https://github.com/banzaicloud/pipeline/pull/2916
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List helm charts operation made backwards compatible #2916

Merged
merged 5 commits into from May 13, 2020
Merged

List helm charts operation made backwards compatible #2916

merged 5 commits into from May 13, 2020

Conversation

@lpuskas
Copy link
Member

@lpuskas lpuskas commented May 12, 2020

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

The helm chartlist response is made similar to the legacy (helm2)

Why?

Each helm chart version was displayed on the UI (broken backwards compatibility)

@lpuskas lpuskas requested review from pepov, tarokkk and sagikazarmark May 12, 2020
@pepov
pepov approved these changes May 12, 2020
@lpuskas lpuskas force-pushed the chartlist branch from 1c9d383 to 89de472 May 13, 2020
@pepov pepov requested a review from sagikazarmark May 13, 2020
@lpuskas lpuskas requested review from sancyx and bonifaido and removed request for tarokkk May 13, 2020
@sancyx
sancyx approved these changes May 13, 2020
@lpuskas lpuskas merged commit 4291e02 into master May 13, 2020
4 checks passed
4 checks passed
Mergeable Mergeable Run has been Completed!
Details
ci Workflow: ci
Details
helm-chart Workflow: helm-chart
Details
license/cla Contributor License Agreement is signed.
Details
@lpuskas lpuskas deleted the chartlist branch May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.