The Wayback Machine - https://web.archive.org/web/20200526153630/https://github.com/mrdoob/three.js/issues/17971
Skip to content

/ three.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterial documentation #17971

Open
donmccurdy opened this issue Nov 20, 2019 · 1 comment
Open

NodeMaterial documentation #17971

donmccurdy opened this issue Nov 20, 2019 · 1 comment
Labels
Documentation
Milestone
rXXX

Comments

@donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Nov 20, 2019

I'd be willing to write documentation for node-based materials in three.js, but need to get a couple questions answered before I feel comfortable doing so.

  1. Is StandardNodeMaterial the material that should be documented, and not MeshStandardNodeMateral? I believe that's true, based on #14572 (comment) and the goal that MeshStandardNodeMaterial will just be a drop-in replacement for MeshStandardMaterial but the docs would be very different if this is wrong.
  2. Which syntax (see #17105 and #17265) should be documented?

I'd prefer to document only one recommended material class, and one recommended syntax style, at the beginning — even if multiple will be available. I'm a bit nervous about having many syntax permutations in use so early with this API.

/cc @sunag @bhouston
@sunag
Copy link
Collaborator

@sunag sunag commented Nov 21, 2019

  1. StandardNodeMaterial is a simplified version of MeshStandardMaterial it avoids some unnecessary inputs and arithmetic operations for node-based material. I started a similar simplified in other natives materials but this generated a lot of extra code. For this reason, maybe in principle, we can initially follow with MeshStandardNodeMateral? Maybe you can be started with nodes individually before adding the materials?

  2. #17105 is an experiment, I think that the syntax to follow is #17265, its syntax is more common for threejs users, it is in fact an extension of the current syntax with some changes in functions parameters order.
@Mugen87 Mugen87 mentioned this issue Dec 28, 2019
Closed
@Mugen87 Mugen87 added this to the rXXX milestone Dec 28, 2019
@Mugen87 Mugen87 mentioned this issue Mar 31, 2020
Closed
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation
3 participants
@sunag @donmccurdy @Mugen87
You can’t perform that action at this time.