The Wayback Machine - https://web.archive.org/web/20200519022738/https://github.com/TheAlgorithms/Python/pull/1996
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi digit extraction algorithm #1996

Merged
merged 14 commits into from May 18, 2020
Merged

Pi digit extraction algorithm #1996

merged 14 commits into from May 18, 2020

Conversation

@ken437
Copy link
Contributor

ken437 commented May 18, 2020

Describe your change:

I added an algorithm that extracts the nth hexadecimal digit of pi

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
ken437 and others added 2 commits May 18, 2020
@ken437
added pi digit extraction formula
83defb6
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
be4c30c
@ken437
Copy link
Contributor Author

ken437 commented May 18, 2020

When I tried to submit my pull request I got an error on the test saying:
Run SKIP="./.*,./other/dictionary.txt,./other/words,./project_euler/problem_22/p022_names.txt"
I don't really understand what this test is doing or why it failed, even though my code runs on my local computer.
@cclauss
Copy link
Member

cclauss commented May 18, 2020

Codespell looks for misspellings like ./maths/bbp_formula.py:4: calulate ==> calculate
@cclauss
cclauss reviewed May 18, 2020
View changes
maths/bbp_formula.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed May 18, 2020
View changes
maths/bbp_formula.py Outdated Show resolved Hide resolved
@ken437
fixed typo in a comment
25732ae
@cclauss
cclauss reviewed May 18, 2020
View changes
maths/bbp_formula.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed May 18, 2020
View changes
maths/bbp_formula.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed May 18, 2020
View changes
maths/bbp_formula.py Outdated Show resolved Hide resolved
ken437 and others added 4 commits May 18, 2020
@ken437
Merge branch 'pi_digit_extract' of https://github.com/ken437/Python i…
90dad2e 
…nto pi_digit_extract
@ken437
updated bbp_formula.py
Loading status checks…
556e58e
@ken437 @cclauss
Update maths/bbp_formula.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ecfead5 
Co-authored-by: Christian Clauss <[email protected]>
@ken437 @cclauss
Update maths/bbp_formula.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
090a15b 
Co-authored-by: Christian Clauss <[email protected]>
@github-actions github-actions bot force-pushed the ken437:pi_digit_extract branch from 27476e7 to 090a15b May 18, 2020
@ken437
Update bbp_formula.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e7e2a38
@cclauss
cclauss reviewed May 18, 2020
View changes
maths/bbp_formula.py Outdated Show resolved Hide resolved
cclauss and others added 6 commits May 18, 2020
@cclauss
Update and rename bbp_formula.py to bailey_borwein_plouffe.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6bd5666
github-actions github-actions
updating DIRECTORY.md
f7e8511
@cclauss
calculate
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
800b730
@cclauss
"".join(bailey_borwein_plouffe(i) for i in range(1, 12))
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6117cdb
@cclauss
Update bailey_borwein_plouffe.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
46db627
@cclauss
Update bailey_borwein_plouffe.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
925c851
@cclauss
cclauss approved these changes May 18, 2020
View changes
@cclauss cclauss merged commit 77f3888 into TheAlgorithms:master May 18, 2020
1 of 2 checks passed
1 of 2 checks passed
codespell
Details
Travis CI - Pull Request Build Errored
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated tests are failing
3 participants
@ken437 @cclauss @TheSuperNoob
You can’t perform that action at this time.