The Wayback Machine - https://web.archive.org/web/20200519020628/https://github.com/TheAlgorithms/Python/pull/1997
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hill_cipher.py: gcd() -> greatest_common_divisor() #1997

Merged
merged 5 commits into from May 18, 2020
Merged

hill_cipher.py: gcd() -> greatest_common_divisor() #1997

merged 5 commits into from May 18, 2020
+53 −55

Conversation

@cclauss
Copy link
Member

cclauss commented May 18, 2020

Describe your change:

  • Add an algorithm?
  • Cleanup an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 2 commits May 18, 2020
@cclauss
hill_cipher.py: gcd() -> greatest_common_divisor()
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a0bbc67
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
3d8eb36
@github-actions github-actions bot force-pushed the greatest_common_divisor branch from d3d1683 to 3d8eb36 May 18, 2020
cclauss and others added 3 commits May 18, 2020
@cclauss
import string
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c5ca569
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
696a3d0
@poyea
Change matrix to array
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
36c01f9 
Add more tests
@poyea
poyea approved these changes May 18, 2020
View changes
Copy link
Member

poyea left a comment

It seems that all PendingDeprecationWarnings are resolved.
@cclauss cclauss merged commit 38d2e98 into master May 18, 2020
5 checks passed
5 checks passed
build
Details
codespell
Details
codespell
Details
build
Details
Travis CI - Pull Request Build Passed
Details
@cclauss cclauss deleted the greatest_common_divisor branch May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@cclauss @poyea
You can’t perform that action at this time.