The Wayback Machine - https://web.archive.org/web/20200521092326/https://github.com/psf/requests/issues/5371
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to access the latest en documentation from doc.python-requests.org domain causes a faulty redirect and a HTTP404 #5371

Open
psiyan opened this issue Feb 28, 2020 · 7 comments

Comments

@psiyan
Copy link

@psiyan psiyan commented Feb 28, 2020

When using the url http://docs.python-requests.org/en/latest/, it redirects to https://2.python-requests.org//en/latest/ (notice the extra / before en). This causes a HTTP 404.

Expected Result

The redirect should be to https://2.python-requests.org/en/latest/

Actual Result

HTTP 404

Reproduction Steps

Try to visit the latest en documentation for requests using the link http://docs.python-requests.org/en/latest/, for example from certifi

System Information

Not applicable

@deveshks
Copy link

@deveshks deveshks commented Mar 22, 2020

I wanted to contribute a fix for it, and was trying to find in the source code where this is defined but I couldn't find it.
But after looking at https://docs.readthedocs.io/en/stable/user-defined-redirects.html, seems like the redirects are defined somewhere else outside the source code. (It starts with Log into your readthedocs.org account.)

In that case, this might not be a good first issue for someone to look at, as it is listed in https://github.com/psf/requests/contribute

@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Apr 6, 2020

@nateprewitt do you by chance have access to the project on read the docs? If so could you share access to my user? (same username: ewdurbin)

@nateprewitt
Copy link
Member

@nateprewitt nateprewitt commented Apr 6, 2020

@ewdurbin, I don’t have access to any of the doc infrastructure actually. We’d need @kennethreitz to get us added.

@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Apr 7, 2020

@nateprewitt do you have a RTD username I can add to the project?

@nateprewitt
Copy link
Member

@nateprewitt nateprewitt commented Apr 7, 2020

It should be the same nateprewitt. Thanks!

@deveshks
Copy link

@deveshks deveshks commented Apr 7, 2020

Hi @ewdurbin , @nateprewitt

Thanks for responding. If I understand correctly, the RTD username will help solve this issue as it will grant access to readthedocs?

@nateprewitt
Copy link
Member

@nateprewitt nateprewitt commented Apr 7, 2020

Hi @deveshks, apologies for the back and forth. Yes, I think we're getting RTD setup so we have proper access and then can hopefully address the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.